OBS-361: Remove tini from all Docker containers. #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
approved these changes
Oct 28, 2024
willkg
reviewed
Oct 28, 2024
| @@ -196,6 +196,7 @@ services: | |||
| ports: | |||
| - "${EXPOSE_SENTRY_PORT:-8090}:8090" | |||
| command: run --host 0.0.0.0 --port 8090 | |||
| stop_signal: SIGINT | |||
There was a problem hiding this comment.
We can remove tini from the fakesentry container in docker/images/fakesentry/Dockerfile.
There was a problem hiding this comment.
Oh, you did that already. I'm surprised it needs this, then.
There was a problem hiding this comment.
I don't know why it needs this, but I tested that it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tini process was originally added to make Docker comtainers quite properly when receiving the TERM signal on
docker compose stop. Some containers don't react to this signal, so terminating them will hang for ten seconds before Docker Compose sends SIGKILL.This change removes tini evertywhere while ensuring container shutdown still happens on the first signal. for some containers, I added the correct signal in
docker-compose.ymlusing thestop_signaldirective. For the frontend containers I made sure the shell script usesexecto start the actual main process, so there shell doesn't linger in the background to block signals. For the oidc-provider, I filed a PR with a similar change.https://mozilla-hub.atlassian.net/browse/OBS-361