-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added build-locales script #1705
Conversation
110eaf0
to
d36803e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me and is a good start to create and build the locale process.
This is ready to be merged, can you maybe resolve the conflicts first so that I can merge this easily later?
463abaf
to
dce1aca
Compare
This should work once #1702 is merged. Since I've committed the config file over there, I haven't added it over here to avoid duplication. |
#1702 just got merged, mind updating this PR then? |
aac7053
to
281896a
Compare
Hey @EnTeQuAk When I test this locally I get
Can you point me to the right direction? |
Sorry for the hiccup and weird test breakage, #1749 just got merged and once you rebase your branch to master tests should be working fine again :) |
@ravneette hey, how is it going? Mind merging in master into this PR so that we can land this? |
Hey |
186850b
to
732c705
Compare
Thanks for the rebase and update, just merged it. |
In Reference to #1535
This PR adds the build-locales script in the bin folder to create js files from po files.
Might have merge conflicts with #1702