Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build-locales script #1705

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Added build-locales script #1705

merged 3 commits into from
Jan 17, 2018

Conversation

ravneette
Copy link
Contributor

In Reference to #1535

This PR adds the build-locales script in the bin folder to create js files from po files.
Might have merge conflicts with #1702

EnTeQuAk
EnTeQuAk previously approved these changes Jan 8, 2018
Copy link
Contributor

@EnTeQuAk EnTeQuAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me and is a good start to create and build the locale process.

This is ready to be merged, can you maybe resolve the conflicts first so that I can merge this easily later?

@ravneette
Copy link
Contributor Author

This should work once #1702 is merged. Since I've committed the config file over there, I haven't added it over here to avoid duplication.
That's why it might fail right now,.

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Jan 9, 2018

#1702 just got merged, mind updating this PR then?

@ravneette
Copy link
Contributor Author

Hey @EnTeQuAk

When I test this locally I get

● Test suite failed to run

    EISDIR: illegal operation on a directory, read
        at Error (native)
      
      at Object.readSync (node_modules/jest-cli/node_modules/graceful-fs/polyfills.js:138:28)

Can you point me to the right direction?
This is the only error for all three of my open PR's.

@EnTeQuAk
Copy link
Contributor

Sorry for the hiccup and weird test breakage, #1749 just got merged and once you rebase your branch to master tests should be working fine again :)

@EnTeQuAk
Copy link
Contributor

@ravneette hey, how is it going? Mind merging in master into this PR so that we can land this?

@ravneette
Copy link
Contributor Author

Hey
Sorry about that. Not sure how I missed that comment ^. Bringing up to date now

@EnTeQuAk EnTeQuAk merged commit 6031465 into mozilla:master Jan 17, 2018
@EnTeQuAk
Copy link
Contributor

Thanks for the rebase and update, just merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants