Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup dependency mess #1749

Merged
merged 7 commits into from
Jan 11, 2018
Merged

Fixup dependency mess #1749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1963afe
chore(package): update webpack-dev-server to version 2.10.1
greenkeeper[bot] Jan 11, 2018
9bedfb5
chore(package): update jest to version 22.0.5
greenkeeper[bot] Jan 11, 2018
941b044
Merge branch 'greenkeeper/jest-22.0.5' of github.com:mozilla/addons-l…
EnTeQuAk Jan 11, 2018
7b223fd
Make sure we run yarn to install dependency updates
EnTeQuAk Jan 11, 2018
0fe05c4
Downgrade to jest 22.0.4 which seems to be working fine
EnTeQuAk Jan 11, 2018
ee90eff
Commit yarn lock file
EnTeQuAk Jan 11, 2018
4ad882b
Remove explicit yarn call
EnTeQuAk Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"is-mergeable-object": "1.1.0",
"isparta": "4.0.0",
"jest": "22.0.4",
"jest-cli": "22.0.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it looks that is this explicit dependency on jest-cli that is fixing the issue

I think that we can remove the "jest" dependency above it, so that we don't need to keep them in sync when we upgrade jest (I tried locally and it worked fine).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's actually true but given that jest only has jest-cli as a dependency we don't have to pin anything right now. Once they pin jest-cli we can get rid of the explicit dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

"jest-raw-loader": "1.0.1",
"json-loader": "0.5.7",
"load-grunt-configs": "1.0.0",
Expand All @@ -76,7 +77,7 @@
"sinon": "4.1.4",
"tar": "4.2.0",
"webpack": "3.10.0",
"webpack-dev-server": "2.10.0"
"webpack-dev-server": "2.10.1"
},
"dependencies": {
"ajv": "5.5.2",
Expand Down
Loading