Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(circleci): bump nodejs version to from v16 to v18 #5418

Merged
merged 2 commits into from
Sep 9, 2024
Merged

chore(circleci): bump nodejs version to from v16 to v18 #5418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a254395
chore(circleci): bump nodejs version to from v16 to v18
rpl Aug 23, 2024
c0725c0
fix: Bump nodejs version in package.json manifest
rpl Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@ references:
working_directory: ~/addons-linter
docker:
# This is the NodeJS version we run in production.
- image: cimg/node:16.19
- image: cimg/node:18.20

defaults-next: &defaults-next
<<: *defaults
docker:
# This is the next NodeJS version we will support.
- image: cimg/node:18.15
- image: cimg/node:20.17

defaults-alternate: &defaults-alternate
<<: *defaults
docker:
# This is an alternate Node version we support or want to support in the
# (far) future. It can either be lower or higher than the current Node
# version we run in production.
- image: cimg/node:19.6
- image: cimg/node:22.7

restore_build_cache: &restore_build_cache
restore_cache:
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"addons-linter": "bin/addons-linter"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18.0.0"
},
"browserslist": [
"node >=16.0.0"
"node >=18.0.0"
],
"scripts": {
"build": "node scripts/build-locales && webpack --bail --stats-error-details true --color --config webpack.config.js",
Expand Down