Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(circleci): bump nodejs version to from v16 to v18 #5418

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

rpl
Copy link
Member

@rpl rpl commented Aug 23, 2024

This PR bumps the nodejs versions used by the circleci jobs:

  • test: to v18 (from v16)
  • test-next: to v20 (from v18)
  • test-alternate: to v22 (from v19)

Fixes test job issue while running recent web-ext tests on a recent unreleased web-ext version where nodejs >= 18 is required (e.g. see example failure here), introduced as a side effect of the changes from mozilla/web-ext#3217.

@rpl rpl requested a review from willdurand August 23, 2024 20:40
This was referenced Aug 25, 2024
@fregante
Copy link
Contributor

fregante commented Aug 25, 2024

If you update the tests you should probably also change the supported versions in package.json:

"engines": {
"node": ">=16.0.0"
},
"browserslist": [
"node >=16.0.0"
],

Alternatively, if you don't want to change this package/tests yet, we can change web-ext to import { Blob } from 'url' instead of relying on the globals; those are supported in Node v16.

But dropping Node 16 support is likely a good idea anyway, to match web-ext and because it reached EOL a year ago: https://endoflife.date/nodejs

@willdurand
Copy link
Member

Yeah, I think we want to update the package.json file here to

@rpl
Copy link
Member Author

rpl commented Sep 5, 2024

Yeah, I think we want to update the package.json file here to

yep, that's definitely right. I just updated this PR to also include the bump of the nodejs version in the addons-linter package.json.

@willdurand willdurand merged commit 3d4f686 into mozilla:master Sep 9, 2024
4 checks passed
@willdurand
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants