report appeals for extensions to a different queue #22851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15161
Description
Route appeals for decisions on extensions (that were made in Cinder) to T&S's escalation queue, rather than the original
listings
queue.Context
There's some strictly unnecessary refactoring of
get_entity_helper
andCinderAddon
from an earlier version of the patch when I went a different direction but I've kept it because it's pretty small and I like it better.Testing
Like most cinder related patches, it's a bit of pain to set up fully. To get to the state where you can test this you need:
ContentDecision
, or updating anotherContentDecision
instance, but it's out of scope for this testing detail to explain exactly how 😛)To test the patch itself:
amo-escalations
("T&S Escalations") queue, rather than in the AMO dev Listings queue.Bonus testing would be to repeat all of this with a theme and a non-add-on content type (e.g. collection) to check those go into their original queues in Cinder; plus appeals on reviewer tools decisions also go to their original (amo dev addon infringement) queue.
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.