-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a-c and fenix branch build tests [ac: main] [fenix: main] #4932
Conversation
4a8a396
to
9959f36
Compare
9959f36
to
a74456d
Compare
899eb29
to
cdf90f9
Compare
cdf90f9
to
e1a8b88
Compare
7c37e7b
to
224174a
Compare
1eed799
to
36b3dd4
Compare
Codecov Report
@@ Coverage Diff @@
## main #4932 +/- ##
=======================================
Coverage 38.56% 38.56%
=======================================
Files 166 166
Lines 12388 12388
=======================================
Hits 4778 4778
Misses 7610 7610 Continue to review full report at Codecov.
|
b03bd51
to
c6e5cee
Compare
c46d219
to
c59f746
Compare
c59f746
to
6ae4264
Compare
I never thought I would see the day, but all the tests are green! I think this is finally ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH MY - THIS IS BEAUTIFUL 🚀 💯
- Made the android-components tests work more like the ones from android-components CI - Split up the tests by project - Updated which gradle tasks we run and allow the tasks to vary per-project. My goal was to make this equivelent to the android-components `taskcluster/ci/build/kind.yml` file. - Updating android platform verison to 31 - Download robolectric and maven ahead of time, this seems to fix the test errors. - Build all architectures, not just x86 - Customize fetches based on which repo we're building from. This makes each task fetch less total data, which seems to fix some intermittent errors I was seeing. - Added a `git rev-parse` to the pre-gradlew commands. This way we can easily see the commit IDs. - Update branch build regex: - Allow specifying the repo owner - allow '.' chars - Support both `a-c: [branch]` and `ac: [branch]`
6ae4264
to
41e55b4
Compare
I'm just making this PR to test the branch build code, please don't merge.
Pull Request checklist
[ci full]
to the PR title.