Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a-c and fenix branch build tests [ac: main] [fenix: main] #4932

Merged
merged 1 commit into from
May 19, 2022

Conversation

bendk
Copy link
Contributor

@bendk bendk commented May 2, 2022

I'm just making this PR to test the branch build code, please don't merge.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@bendk bendk force-pushed the branch-build-test-fixes branch 4 times, most recently from 4a8a396 to 9959f36 Compare May 2, 2022 18:50
@bendk bendk force-pushed the branch-build-test-fixes branch from 9959f36 to a74456d Compare May 2, 2022 20:55
@bendk bendk changed the title [WIP] Attempt ot fix a-c and fenix branch build tests [a-c: main] [fenix: main] [WIP] Attempt ot fix a-c and fenix branch build tests [a-c: application-services-93.0.1] [fenix: application-services-93.0.1] May 2, 2022
@bendk bendk force-pushed the branch-build-test-fixes branch 3 times, most recently from 899eb29 to cdf90f9 Compare May 3, 2022 14:50
@bendk bendk changed the title [WIP] Attempt ot fix a-c and fenix branch build tests [a-c: application-services-93.0.1] [fenix: application-services-93.0.1] [WIP] Attempt ot fix a-c and fenix branch build tests [ac: application-services-93.0.1] [fenix: application-services-93.0.1] May 3, 2022
@bendk bendk force-pushed the branch-build-test-fixes branch from cdf90f9 to e1a8b88 Compare May 3, 2022 17:44
@bendk bendk changed the title [WIP] Attempt ot fix a-c and fenix branch build tests [ac: application-services-93.0.1] [fenix: application-services-93.0.1] [WIP] Attempt ot fix a-c and fenix branch build tests [ac: bendk/application-services-93.0.1] [fenix: bendk/application-services-93.0.1] May 3, 2022
@bendk bendk force-pushed the branch-build-test-fixes branch 6 times, most recently from 7c37e7b to 224174a Compare May 5, 2022 18:37
@bendk bendk changed the title [WIP] Attempt ot fix a-c and fenix branch build tests [ac: bendk/application-services-93.0.1] [fenix: bendk/application-services-93.0.1] [WIP] Attempt ot fix a-c and fenix branch build tests [ac: main] [fenix: main] May 10, 2022
@bendk bendk force-pushed the branch-build-test-fixes branch 8 times, most recently from 1eed799 to 36b3dd4 Compare May 15, 2022 16:49
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #4932 (db53d13) into main (c23f5cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4932   +/-   ##
=======================================
  Coverage   38.56%   38.56%           
=======================================
  Files         166      166           
  Lines       12388    12388           
=======================================
  Hits         4778     4778           
  Misses       7610     7610           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23f5cf...db53d13. Read the comment docs.

@bendk bendk force-pushed the branch-build-test-fixes branch 3 times, most recently from c46d219 to c59f746 Compare May 19, 2022 13:52
@bendk bendk mentioned this pull request May 19, 2022
4 tasks
@bendk bendk changed the title [WIP] Attempt ot fix a-c and fenix branch build tests [ac: main] [fenix: main] Attempt ot fix a-c and fenix branch build tests [ac: main] [fenix: main] May 19, 2022
@bendk bendk changed the title Attempt ot fix a-c and fenix branch build tests [ac: main] [fenix: main] Fix a-c and fenix branch build tests [ac: main] [fenix: main] May 19, 2022
@bendk
Copy link
Contributor Author

bendk commented May 19, 2022

I never thought I would see the day, but all the tests are green! I think this is finally ready to merge.

Copy link
Contributor

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH MY - THIS IS BEAUTIFUL 🚀 💯 :shipit:

- Made the android-components tests work more like the ones from android-components CI
  - Split up the tests by project
  - Updated which gradle tasks we run and allow the tasks to vary
    per-project.  My goal was to make this equivelent to the
    android-components `taskcluster/ci/build/kind.yml` file.
- Updating android platform verison to 31
- Download robolectric and maven ahead of time, this seems to fix the
  test errors.
- Build all architectures, not just x86
- Customize fetches based on which repo we're building from.  This makes
  each task fetch less total data, which seems to fix some intermittent
  errors I was seeing.
- Added a `git rev-parse` to the pre-gradlew commands.  This way we can
  easily see the commit IDs.
- Update branch build regex:
  - Allow specifying the repo owner
  - allow '.' chars
  - Support both `a-c: [branch]` and `ac: [branch]`
@bendk bendk merged commit ebec923 into mozilla:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants