Adding documentation on branch builds #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
commented
May 19, 2022
| needs to be resolved. | ||
| - To get the APK, navigate to `branch-build-fenix-build` and download `app-x86-debug.apk` from the artifacts list | ||
| - `branch-build-ac-test.*` are the android-components tests tasks. These are split up by gradle project, which matches | ||
| how the android-components CI handles things. Running all the tests together often leads to failures. |
There was a problem hiding this comment.
This is not true yet, but it will be true once we merge #4932. There's still some work to do on that, but I'm very confident that splitting up the tests like this is a good idea. I'm hoping to open a PR for that one soon.
tarikeshaq
suggested changes
May 19, 2022
There was a problem hiding this comment.
The doc looks great! 🚀 🔥 🔥
Only requesting changes to add it to docs/SUMMARY.md so it's visible to readers on https://mozilla.github.io/application-services/book/index.html
|
This also might be something we can add to https://github.com/mozilla/application-services/blob/main/.github/pull_request_template.md as an optional step 😬 (I don't feel strongly about it though, not sure how much value it adds) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.