-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Glean back to the iOS megazord #5009
Conversation
Codecov ReportBase: 41.45% // Head: 41.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5009 +/- ##
==========================================
- Coverage 41.45% 41.28% -0.18%
==========================================
Files 167 168 +1
Lines 12620 12628 +8
==========================================
- Hits 5232 5213 -19
- Misses 7388 7415 +27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3dcf93a
to
07fac9d
Compare
There's one more thing to do for this, and that's add test coverage for the metric collection in Rust, I ran into some issues with that and need to speak with Jan-Erik to see what's going on. It also seems to fail some checks due to the |
cac7e84
to
2ebfcf1
Compare
This needs to land in concert with mozilla/application-services#5009 and downstream PRs in Focus iOS and Firefox iOS
Seems I forgot to move the exposure event to Rust completely for iOS... not quite ready yet. |
a7f92f6
to
b61b2b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking lovely. 😻
I have added comments which are mostly filing bugs and questions for my own understanding.
I haven't reviewed anything in xcodeproj files, or .h files, and so we should probably ask one of the iOS teams to look at those and give a r+.
From my point of view, this is brilliant, it's been a long time coming, so thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton @travis79 🚀 🎉 !! Once we get this through we should have a good story for iOS
I had a couple of blocking thoughts/comments that we might need to work out before we land this:
- The comment about impact on android and possibly feature gating
- The uniffi version compatibility comment
The rest are nits and questions. I'll timebox sometime to think about the uniffi
comment and see if we can comeup with a good way to move forward!
09acbaa
to
f8364da
Compare
f8364da
to
0af606a
Compare
e084833
to
5d90897
Compare
dc7f15e
to
b9d4a88
Compare
This needs to land in concert with mozilla/application-services#5009 and downstream PRs in Focus iOS and Firefox iOS Strip Nimbus Utils directory in generate.sh
c7eff54
to
352ca08
Compare
352ca08
to
5caba36
Compare
26fc521
to
87c23b4
Compare
87c23b4
to
e59ba75
Compare
This includes conditional compilation for this feature only on iOS, Android will still need to record things in Kotlin for the time being.
7f20526
to
3166769
Compare
3166769
to
ba1b12b
Compare
This needs to land in concert with mozilla/application-services#5009 and downstream PRs in Focus iOS and Firefox iOS Strip Nimbus Utils directory in generate.sh
@travis79 since this has gotten a little stale, do you know what the priority of this work is now? (i.e do we expect we'll get to it anytime soon?) I don't object to keeping the PR open until we get to it, just curious what a timeline might look like if we have one? |
@tarikeshaq Yes, the priorities on this shifted a bit. This is still desirable to do but I don't have time to get back to it immediately. Ultimately I'd love to be able to solve both iOS and Android when we get back to this. Let's close this in favor of starting fresh without any bitrot to deal with. |
This is so we can use it to record metrics in Rust on iOS