-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enroll/Unenroll Failed events to Nimbus #5137
Conversation
0b599ff
to
4c04f2d
Compare
Codecov ReportBase: 39.00% // Head: 39.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5137 +/- ##
==========================================
+ Coverage 39.00% 39.06% +0.06%
==========================================
Files 169 169
Lines 12461 12486 +25
==========================================
+ Hits 4860 4878 +18
- Misses 7601 7608 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abe1471
to
d811d27
Compare
Request for data collection review form
The purpose of these events are for Nimbus monitoring to answer questions about failure to enroll or unenroll.
These metrics are important for monitoring of Nimbus experiments, to ensure proper experiment execution, and to be equivalent to the metrics collected in Firefox Desktop.
No other telemetry was available to answer these questions.
No
Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
This collection is documented in the Glean Dictionary and in the metrics.yaml
I want to permanently monitor this data - Travis Long (tlong@mozilla.com)
All channels, countries, and locales
Through the standard telemetry preference in the application settings
Through Jetstream analysis of Nimbus experiments and through Looker.
With experiment team members and experiment owners
No cc @eliserichards for data-review? |
components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/Nimbus.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A drive by. All looking good so far; @jeddai has said everything that I would've.
d811d27
to
f7ac3b8
Compare
This is still awaiting data-review, and could conflict with my plan to land #5009 this week. Landing the other PR takes priority over this one, since it would be more difficult to modify #5009 after this lands than vice versa. So, while this awaits data-review, I'll land the other PR and then update this one to record these events in Rust for iOS. |
Data Review Form (to be filled by Data Stewards)
Resultdata-review+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-review+
f7ac3b8
to
ff6c82c
Compare
Adding events to bubble up from Rust
ff6c82c
to
8e8dbf1
Compare
No description provided.