Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow downstream builds to self-identify for /v1/country, 404 /v1/geolocate #152

Merged
merged 11 commits into from
Apr 19, 2024

Conversation

alexcottner
Copy link
Contributor

@alexcottner alexcottner commented Apr 3, 2024

This PR is a combination of small changes, mostly from feedback around MLS migration:

  1. Adds parameter for api keys file path
  2. Allows custom keys to be provided to /v1/country endpoint (fixes Allow downstream firefox builds to self-select API keys to /country #151)
  3. Adds unit tests around v1/country for keys
  4. Removes route to /v1/geolocate, causing a 404 to be returned
  5. Makes a small adjustment to utils.rs for an updated lint rule
  6. Updates readme with notes on MLS endpoints

@alexcottner alexcottner changed the title WIP - Downstream key changes Allow downstream builds to self-identify for /v1/country, 404 /v1/geolocate Apr 9, 2024
@alexcottner alexcottner marked this pull request as ready for review April 9, 2024 19:21
src/endpoints/country.rs Show resolved Hide resolved
src/endpoints/country.rs Show resolved Hide resolved
src/endpoints/country.rs Outdated Show resolved Hide resolved
src/endpoints/country.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the silent behaviour when no keys are loaded, this should be ok

@alexcottner
Copy link
Contributor Author

Apart from the silent behaviour when no keys are loaded, this should be ok

Going to work on that in a followup. Thinking maybe we should just load those into settings along with the env vars.

@alexcottner alexcottner merged commit 4600b2f into master Apr 19, 2024
2 checks passed
@alexcottner alexcottner deleted the downstream-key branch April 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow downstream firefox builds to self-select API keys to /country
3 participants