Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved API key loading/caching to startup. Added error logs and tests. #153

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Moved API key loading/caching to startup. Added error logs and tests. #153

merged 2 commits into from
Apr 23, 2024

Conversation

alexcottner
Copy link
Contributor

This is a followup from #152 .

  • Moved API key file loading to startup rather than lazy loading.
  • Added error logging for if the api keys file is missing or cannot be parsed.
  • Added test scenarios to verify logging worked as expected.

@alexcottner alexcottner marked this pull request as ready for review April 22, 2024 18:41
@alexcottner alexcottner merged commit efd97ca into master Apr 23, 2024
2 checks passed
@alexcottner alexcottner deleted the keys-move branch April 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamalama grahamalama grahamalama approved these changes

@leplatrem leplatrem leplatrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcottner @leplatrem @grahamalama