-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only sync Glean.js #1808
Only sync Glean.js #1808
Conversation
@rosahbruno a few observations on this:
Note that I see 13 unit tests failing locally, not 2:
By splitting the PR as advised above we should be more confident in the changes we make. |
Yep, this makes sense. I will break these into separate PRs.
I will take a look |
4bda4dc
to
01844c7
Compare
a3c4d57
to
1f01665
Compare
1f01665
to
c974f14
Compare
c974f14
to
8b3c4ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking comments or arguments from me. That was a lot of await
and async
to remove!
Co-authored-by: Travis Long <tlong@mozilla.com>
This PR updates Glean.js to be completely synchronous with only a
web
implementation.The 3 other platforms are going to undergo changes
Both the node and web extension platforms are going to be added back in later. They are being removed now so we can focus on web and build a new architecture that allows for platform OR framework specific implementations with their own auto-instrumentation.
Important updates included in this PR
async
/sync
file structuredispatcher
since it is not needed in the sync implementationplugins
as they are asynchronous and not used in any active projects