Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QT #1810

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Remove QT #1810

merged 10 commits into from
Nov 9, 2023

Conversation

Dexterp37
Copy link
Contributor

@Dexterp37 Dexterp37 commented Nov 8, 2023

This removes QT and rolls back some of the changes that were made to the APIs in order to support the QT platform (FYI @brizental as your team was the only consumer of this API).

TODO:

  • Add a breaking change to the changelog
  • Verify that everything else works in a product
  • Check if it's ok to remove the unsafe generateUUIDv4 fallback that was introduced due to Qt. (It was not ok, as we might still need this for webextensions that this version still supports).

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@Dexterp37 Dexterp37 requested a review from rosahbruno November 8, 2023 12:15
@Dexterp37 Dexterp37 self-assigned this Nov 8, 2023
@auto-assign auto-assign bot requested a review from travis79 November 8, 2023 12:15
@Dexterp37 Dexterp37 removed the request for review from travis79 November 8, 2023 12:15
@Dexterp37 Dexterp37 mentioned this pull request Nov 8, 2023
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I'm a little concerned about the files that appear to have every line changed, did we change line endings from Linux-y to Windows-y maybe?

automation/size/docs.js Outdated Show resolved Hide resolved
@Dexterp37 Dexterp37 force-pushed the remove-qt branch 2 times, most recently from c437c3a to 0cd6563 Compare November 8, 2023 14:06
Copy link
Contributor

@rosahbruno rosahbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we may be able to drop the sqlite dev dependency in the /glean package.json since it was only being used by QT.

Also looks like there may be some KnownOperatingSystems we may be able to drop now, but probably not a big deal if we didn't.
https://github.com/mozilla/glean.js/blob/main/glean/src/core/platform_info/shared.ts#L23-L26

Besides that, everything looks good. I will try and run this in a project and make sure everything is working as expected.

@rosahbruno
Copy link
Contributor

@Dexterp37
I ran this version of Glean with the debug ping viewer via this branch https://github.com/rosahbruno/glean.js/tree/remove-qt-dist and everything worked as expected 👍

@Dexterp37
Copy link
Contributor Author

It looks like we may be able to drop the sqlite dev dependency in the /glean package.json since it was only being used by QT.

Good call, remove that!

Also looks like there may be some KnownOperatingSystems we may be able to drop now, but probably not a big deal if we didn't. https://github.com/mozilla/glean.js/blob/main/glean/src/core/platform_info/shared.ts#L23-L26

Yes, saw that and thought to remove it as I wasn't really sure and the risk didn't seem worth it.

Besides that, everything looks good. I will try and run this in a project and make sure everything is working as expected.

Thanks!

@Dexterp37 Dexterp37 merged commit b4bd125 into mozilla:main Nov 9, 2023
@Dexterp37 Dexterp37 deleted the remove-qt branch November 9, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants