-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove QT #1810
Remove QT #1810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I'm a little concerned about the files that appear to have every line changed, did we change line endings from Linux-y to Windows-y maybe?
c437c3a
to
0cd6563
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we may be able to drop the sqlite
dev dependency in the /glean
package.json
since it was only being used by QT.
Also looks like there may be some KnownOperatingSystems we may be able to drop now, but probably not a big deal if we didn't.
https://github.com/mozilla/glean.js/blob/main/glean/src/core/platform_info/shared.ts#L23-L26
Besides that, everything looks good. I will try and run this in a project and make sure everything is working as expected.
@Dexterp37 |
This additionally removes the ability to pass architecture and os version to the Glean config, which was exclusively added to support Qt.
Good call, remove that!
Yes, saw that and thought to remove it as I wasn't really sure and the risk didn't seem worth it.
Thanks! |
This removes QT and rolls back some of the changes that were made to the APIs in order to support the QT platform (FYI @brizental as your team was the only consumer of this API).
TODO:
generateUUIDv4
fallback that was introduced due to Qt. (It was not ok, as we might still need this for webextensions that this version still supports).Pull Request checklist
glean/
folder, run:npm run test
Runs all testsnpm run lint
Runs all lintersCHANGELOG.md
or an explanation of why it does not need onemozilla/glean
repository