Skip to content

Commit

Permalink
ci: Fail QNS run on Rust panic (#1976)
Browse files Browse the repository at this point in the history
* ci: Fail QNS run on Rust panic

So we hopefully catch interop panics in CI earlier.

* Fix condition

* check logs

* where

* Again

* Again

* Again

* Done

* if: always()

---------

Signed-off-by: Lars Eggert <lars@eggert.org>
  • Loading branch information
larseggert authored Jul 17, 2024
1 parent e82da39 commit 9e3ff0d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/actions/quic-interop-runner/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@ runs:
# Don't fail CI if the interop test fails
set -o pipefail
python -u run.py $ARGS 2>&1 | tee ../summary.txt || true
# But do fail if any log contains 'RUST_BACKTRACE=full', which indicates a panic
# (that we assume happened in neqo.)
for log in ../logs/*/*/output.txt; do
if grep -q 'RUST_BACKTRACE=full' "$log"; then
echo "Panic detected in $log"
tail -n 50 "$log"
exit 1
fi
done
shell: bash

- uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/qns.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ jobs:
name: Report results
needs: run-qns
runs-on: ubuntu-latest
if: always()
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
Expand Down

0 comments on commit 9e3ff0d

Please sign in to comment.