Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fail QNS run on Rust panic #1976

Merged
merged 11 commits into from
Jul 17, 2024
Merged

ci: Fail QNS run on Rust panic #1976

merged 11 commits into from
Jul 17, 2024

Conversation

larseggert
Copy link
Collaborator

So we hopefully catch interop panics in CI earlier.

@larseggert
ci: Fail QNS run on Rust panic
e3c3525 
So we hopefully catch interop panics in CI earlier.
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (19ec1a9) to head (45a3547).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   94.96%   94.99%   +0.02%     
==========================================
  Files         112      112              
  Lines       36411    36366      -45     
==========================================
- Hits        34579    34547      -32     
+ Misses       1832     1819      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

Failed Interop Tests

QUIC Interop Runner, client vs. server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

Benchmark results

Performance differences relative to e82da39.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [192.06 ns 192.63 ns 193.23 ns]
       change: [-0.3782% +0.0481% +0.4975%] (p = 0.84 > 0.05)

Found 9 outliers among 100 measurements (9.00%)

2 (2.00%) low mild

5 (5.00%) high mild

2 (2.00%) high severe

coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [233.52 ns 234.14 ns 234.79 ns]
       change: [-0.7543% -0.4260% -0.1064%] (p = 0.01 < 0.05)

Found 13 outliers among 100 measurements (13.00%)

5 (5.00%) high mild

8 (8.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [232.57 ns 233.51 ns 234.54 ns]
       change: [-1.3140% -0.8198% -0.3372%] (p = 0.00 < 0.05)

Found 12 outliers among 100 measurements (12.00%)

2 (2.00%) low mild

1 (1.00%) high mild

9 (9.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [214.49 ns 214.69 ns 214.94 ns]
       change: [-1.2432% -0.5422% +0.1558%] (p = 0.14 > 0.05)

Found 14 outliers among 100 measurements (14.00%)

6 (6.00%) high mild

8 (8.00%) high severe

RxStreamOrderer::inbound_frame(): 💔 Performance has regressed.
       time:   [120.49 ms 120.66 ms 120.91 ms]
       change: [+1.3265% +1.5142% +1.7505%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) high mild

1 (1.00%) high severe

transfer/Run multiple transfers with varying seeds: No change in performance detected.
       time:   [51.052 ms 54.103 ms 57.175 ms]
       thrpt:  [69.961 MiB/s 73.932 MiB/s 78.352 MiB/s]
change:
       time:   [-12.582% -5.9786% +1.3674%] (p = 0.11 > 0.05)
       thrpt:  [-1.3490% +6.3588% +14.392%]
transfer/Run multiple transfers with the same seed: No change in performance detected.
       time:   [60.470 ms 67.333 ms 74.132 ms]
       thrpt:  [53.958 MiB/s 59.406 MiB/s 66.149 MiB/s]
change:
       time:   [-20.409% -9.1186% +1.1046%] (p = 0.13 > 0.05)
       thrpt:  [-1.0925% +10.034% +25.642%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [287.78 ms 292.01 ms 296.51 ms]
       thrpt:  [337.25 MiB/s 342.46 MiB/s 347.49 MiB/s]
change:
       time:   [-3.7881% -1.0519% +1.7142%] (p = 0.48 > 0.05)
       thrpt:  [-1.6853% +1.0631% +3.9373%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [412.91 ms 416.29 ms 419.70 ms]
       thrpt:  [23.826 Kelem/s 24.022 Kelem/s 24.219 Kelem/s]
change:
       time:   [-0.6794% +0.4930% +1.6323%] (p = 0.40 > 0.05)
       thrpt:  [-1.6061% -0.4906% +0.6841%]

Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [67.819 ms 68.052 ms 68.328 ms]
       thrpt:  [14.635  elem/s 14.695  elem/s 14.745  elem/s]
change:
       time:   [-2.1209% -0.8984% +0.0631%] (p = 0.11 > 0.05)
       thrpt:  [-0.0631% +0.9066% +2.1669%]

Found 6 outliers among 100 measurements (6.00%)

3 (3.00%) low mild

3 (3.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 119.4 ± 20.7 98.8 195.2 1.00
neqo msquic reno on 272.3 ± 12.5 256.0 297.4 1.00
neqo msquic reno 259.7 ± 8.0 241.8 276.0 1.00
neqo msquic cubic on 289.0 ± 55.1 257.2 443.1 1.00
neqo msquic cubic 267.2 ± 16.1 251.2 295.9 1.00
msquic neqo reno on 165.3 ± 20.0 135.0 214.3 1.00
msquic neqo reno 150.2 ± 21.9 114.9 214.2 1.00
msquic neqo cubic on 151.8 ± 19.1 113.7 197.6 1.00
msquic neqo cubic 172.8 ± 21.3 111.0 207.5 1.00
neqo neqo reno on 182.2 ± 9.8 167.6 200.4 1.00
neqo neqo reno 169.6 ± 10.7 149.5 192.4 1.00
neqo neqo cubic on 174.7 ± 12.5 154.0 204.4 1.00
neqo neqo cubic 180.4 ± 15.9 154.1 215.1 1.00

⬇️ Download logs

@larseggert
Copy link
Collaborator Author

This needs to wait until #1975 is fixed, otherwise all CI will fail.

@github-actions GitHub Actions
Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

mxinden
mxinden approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

.github/actions/quic-interop-runner/action.yml Show resolved Hide resolved
@larseggert larseggert added the needs-review Needs a review by a CODEOWNER. label Jul 17, 2024
@larseggert larseggert removed the needs-review Needs a review by a CODEOWNER. label Jul 17, 2024
@larseggert
Copy link
Collaborator Author

The single remaining failure is Run QNS (neqo-latest vs. neqo), which is because mainline neqo doesn't have #1981 yet.

@larseggert larseggert added this pull request to the merge queue Jul 17, 2024
Merged via the queue into mozilla:main with commit 9e3ff0d Jul 17, 2024
56 of 57 checks passed
@larseggert larseggert deleted the ci-qns-fail-on-panic branch July 17, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@KershawChang KershawChang KershawChang approved these changes

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larseggert @KershawChang @mxinden