Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fail QNS run on Rust panic #1976

Merged
merged 11 commits into from
Jul 17, 2024
Merged

ci: Fail QNS run on Rust panic #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e3c3525
ci: Fail QNS run on Rust panic
larseggert Jul 11, 2024
476fd18
Fix condition
larseggert Jul 11, 2024
cfc8612
check logs
larseggert Jul 11, 2024
8acf23e
where
larseggert Jul 11, 2024
343b530
Again
larseggert Jul 11, 2024
49d648f
Again
larseggert Jul 11, 2024
1b89d56
Again
larseggert Jul 11, 2024
88cf8df
Done
larseggert Jul 11, 2024
38c88d5
Merge branch 'main' into ci-qns-fail-on-panic
larseggert Jul 17, 2024
85e1d21
Merge branch 'main' into ci-qns-fail-on-panic
larseggert Jul 17, 2024
45a3547
if: always()
larseggert Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/actions/quic-interop-runner/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@ runs:
# Don't fail CI if the interop test fails
larseggert marked this conversation as resolved.
Show resolved Hide resolved
set -o pipefail
python -u run.py $ARGS 2>&1 | tee ../summary.txt || true
# But do fail if any log contains 'RUST_BACKTRACE=full', which indicates a panic
# (that we assume happened in neqo.)
for log in ../logs/*/*/output.txt; do
if grep -q 'RUST_BACKTRACE=full' "$log"; then
echo "Panic detected in $log"
tail -n 50 "$log"
exit 1
fi
done
shell: bash

- uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/qns.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ jobs:
name: Report results
needs: run-qns
runs-on: ubuntu-latest
if: always()
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
Expand Down
Loading