Skip to content

Commit

Permalink
Revert "ci: Trigger secondary checks off check.yml (#1984)" (#1987)
Browse files Browse the repository at this point in the history
This reverts commit 735be28.
  • Loading branch information
larseggert authored Jul 16, 2024
1 parent 735be28 commit e05cc70
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 19 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: Bench
on:
workflow_run:
workflows: ["Build Check"]
types: [completed]
workflow_call:
workflow_dispatch:
schedule:
# Run at 1 AM each day, so there is a `main`-branch baseline in the cache.
- cron: '0 1 * * *'
Expand All @@ -20,7 +19,6 @@ permissions: read-all
jobs:
bench:
name: Benchmark
if: github.event.workflow_run.conclusion == 'success'
runs-on: self-hosted
defaults:
run:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build Check
name: CI
on:
push:
branches: ["main"]
Expand Down Expand Up @@ -168,3 +168,8 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
if: matrix.type == 'debug' && matrix.rust-toolchain == 'stable'

bench:
name: "Benchmark"
needs: [check]
uses: ./.github/workflows/bench.yml
8 changes: 4 additions & 4 deletions .github/workflows/firefox.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
name: Firefox
on:
workflow_run:
workflows: ["Build Check"]
types: [completed]
workflow_dispatch:
pull_request:
branches: ["main"]
paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.ref_name }}
Expand All @@ -14,7 +15,6 @@ env:
jobs:
firefox:
name: Build Firefox
if: github.event.workflow_run.conclusion == 'success'
strategy:
fail-fast: false
matrix:
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/mutants.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
name: Find mutants
on:
workflow_run:
workflows: ["Build Check"]
types: [completed]
schedule:
- cron: '42 3 * * 2,5' # Runs at 03:42 UTC (m and h chosen arbitrarily) twice a week.
workflow_dispatch:
pull_request:
branches: ["main"]
paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.ref_name }}
Expand All @@ -12,7 +15,6 @@ permissions: read-all

jobs:
mutants:
if: github.event.workflow_run.conclusion == 'success'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/pr-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ name: PR Comment

on:
workflow_run:
workflows: [QNS, Bench, Firefox]
types: [completed]
workflows: ["QNS", "CI", "Firefox"]
types:
- completed

permissions: read-all

Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/qns.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
name: QNS

on:
workflow_run:
workflows: ["Build Check"]
types: [completed]
push:
branches: ["main"]
paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"]
pull_request:
branches: ["main"]
paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"]
merge_group:
schedule:
# Run at 1 AM each day
- cron: '0 1 * * *'
workflow_dispatch:

concurrency:
Expand All @@ -20,7 +26,6 @@ env:
jobs:
docker-image:
name: Build Docker image
if: github.event.workflow_run.conclusion == 'success'
runs-on: ubuntu-latest
outputs:
imageID: ${{ steps.docker_build_and_push.outputs.imageID }}
Expand Down

0 comments on commit e05cc70

Please sign in to comment.