Revert "ci: Trigger secondary checks off check.yml (#1984)"
#1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 735be28.
Benchmark resultsPerformance differences relative to e05cc70. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [189.74 ns 190.25 ns 190.80 ns]
change: [-0.3928% +0.0952% +0.5842%] (p = 0.71 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [229.72 ns 230.29 ns 230.90 ns]
change: [-0.9146% -0.4325% +0.0124%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [230.57 ns 231.53 ns 232.61 ns]
change: [-1.7825% -0.7348% +0.1070%] (p = 0.13 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [212.65 ns 212.83 ns 213.05 ns]
change: [+0.3976% +0.9539% +1.4818%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [118.72 ms 118.81 ms 118.89 ms]
change: [+0.0800% +0.1789% +0.2864%] (p = 0.00 < 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [50.390 ms 53.380 ms 56.385 ms]
thrpt: [70.941 MiB/s 74.934 MiB/s 79.380 MiB/s]
change:
time: [-12.179% -4.7696% +2.9196%] (p = 0.23 > 0.05)
thrpt: [-2.8368% +5.0085% +13.868%]
transfer/Run multiple transfers with the same seed: No change in performance detected. time: [63.873 ms 70.458 ms 77.046 ms]
thrpt: [51.917 MiB/s 56.771 MiB/s 62.625 MiB/s]
change:
time: [-19.371% -7.9806% +4.8360%] (p = 0.20 > 0.05)
thrpt: [-4.6129% +8.6728% +24.025%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [277.29 ms 282.48 ms 287.75 ms]
thrpt: [347.52 MiB/s 354.01 MiB/s 360.64 MiB/s]
change:
time: [-2.6869% -0.3974% +2.0007%] (p = 0.76 > 0.05)
thrpt: [-1.9615% +0.3990% +2.7611%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [447.23 ms 450.20 ms 453.15 ms]
thrpt: [22.068 Kelem/s 22.212 Kelem/s 22.360 Kelem/s]
change:
time: [-1.0331% -0.0808% +0.9467%] (p = 0.87 > 0.05)
thrpt: [-0.9379% +0.0808% +1.0439%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [68.635 ms 68.997 ms 69.407 ms]
thrpt: [14.408 elem/s 14.493 elem/s 14.570 elem/s]
change:
time: [-0.7899% +0.0184% +0.7813%] (p = 0.96 > 0.05)
thrpt: [-0.7752% -0.0184% +0.7962%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
added a commit
to larseggert/neqo
that referenced
this pull request
Jul 17, 2024
…ozilla#1987) This reverts commit 735be28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 735be28.
Maybe #1985 or #1986 pan out.