ci: Use cargo-machete to check for unused dependencies #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove the ones it found.
mxinden
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
In favor. Used https://github.com/est31/cargo-udeps in the past. Fine with either.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 112 112
Lines 36509 36509
=======================================
Hits 34673 34673
Misses 1836 1836 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to f1c04d2. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [194.70 ns 195.11 ns 195.57 ns]
change: [+0.7723% +1.3967% +1.9220%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed. time: [238.60 ns 239.18 ns 239.81 ns]
change: [+1.4065% +1.9612% +2.4946%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed. time: [239.33 ns 240.18 ns 241.18 ns]
change: [+1.0029% +1.6692% +2.2467%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [215.78 ns 216.04 ns 216.33 ns]
change: [-5.7663% -2.0134% +0.2696%] (p = 0.30 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [118.56 ms 118.62 ms 118.69 ms]
change: [-0.3464% -0.1365% +0.0152%] (p = 0.15 > 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [53.913 ms 56.956 ms 60.061 ms]
thrpt: [66.599 MiB/s 70.229 MiB/s 74.193 MiB/s]
change:
time: [-7.3515% -0.0338% +8.2726%] (p = 0.99 > 0.05)
thrpt: [-7.6405% +0.0338% +7.9348%]
transfer/Run multiple transfers with the same seed: No change in performance detected. time: [70.630 ms 77.089 ms 83.511 ms]
thrpt: [47.898 MiB/s 51.888 MiB/s 56.633 MiB/s]
change:
time: [-1.6695% +10.156% +22.706%] (p = 0.09 > 0.05)
thrpt: [-18.504% -9.2199% +1.6978%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [156.98 ms 168.74 ms 183.54 ms]
thrpt: [544.84 MiB/s 592.63 MiB/s 637.01 MiB/s]
change:
time: [-3.3270% +3.5676% +12.778%] (p = 0.49 > 0.05)
thrpt: [-11.331% -3.4447% +3.4415%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [432.09 ms 435.41 ms 438.74 ms]
thrpt: [22.793 Kelem/s 22.967 Kelem/s 23.143 Kelem/s]
change:
time: [-1.3122% -0.1997% +0.8814%] (p = 0.72 > 0.05)
thrpt: [-0.8737% +0.2001% +1.3297%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [43.677 ms 44.234 ms 44.803 ms]
thrpt: [22.320 elem/s 22.607 elem/s 22.895 elem/s]
change:
time: [-1.6460% +0.1251% +1.9025%] (p = 0.90 > 0.05)
thrpt: [-1.8670% -0.1249% +1.6735%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
KershawChang
approved these changes
Jul 11, 2024
Signed-off-by: Lars Eggert <lars@eggert.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the ones it found.