Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dump filter #872

Closed
wants to merge 7 commits into from
Closed

Feat/dump filter #872

wants to merge 7 commits into from

Conversation

JesseE
Copy link
Contributor

@JesseE JesseE commented Sep 20, 2016

Summary

Proposed change:

  • add spaces parameter to the dump template filter
  • add tests to dump template filter
  • update documentation dump filter

I assign myself to this task

Closes #867.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

(Tick of items by replacing [ ] by [x])

Jesse Eikema added 7 commits September 19, 2016 14:05
# Conflicts:
#	docs/templating.md
change foo dump to items dump consistency

change key types

correcting documentation dump filter

perfecting dump documentation

perfecting dump testing

added different indentation

complete tests
@vecmezoni
Copy link
Collaborator

Please prefer rebase over merge

@JesseE JesseE closed this Sep 20, 2016
@JesseE
Copy link
Contributor Author

JesseE commented Sep 20, 2016

yes thats a better Idea thanks.

#868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump filter needs spaces parameter for better readability
2 participants