Feat/dump filter spaces #868
Conversation
| @@ -972,7 +973,69 @@ a b c d e f | |||
| ### dump (object) | |||
There was a problem hiding this comment.
signature changed from dump (object) to dump (object, [space]), but I think in any case simply dump would be better as heading.
| **Input** | ||
|
|
||
| ```jinja | ||
| {% set items = [{ a : 1}, { b : false}] %} |
There was a problem hiding this comment.
I think you want to illustrate dump works on different primitives, so I'd use ['a', 1, { b : false}] in all examples in the docs. The only thing you'd change between examples is the space parameter (none, 2 spaces, 1 tab).
| @@ -86,6 +86,18 @@ | |||
| finish(done); | |||
| }); | |||
|
|
|||
| it('dump', function(done) { | |||
| equal('{{ {"container":[{\'a\': true}, {\'b\': 2 }]} | dump }}', | |||
There was a problem hiding this comment.
Again I think you want to illustrate dump works on different primitives, so I'd use ['a', 1, { b : false}] (same as in doc examples) in all tests. The only thing you'd change between test cases is the space parameter (none, 2 spaces, 1 tab).
JesseE
force-pushed
the
feat/dump-filter-spaces
branch
from
a45f9e7
to
040e590
Compare
add dump filter documentation added changelog update Fix mobile viewport (meta) (mozilla#865) closes mozilla#860 Order builtin filters alphabetically (mozilla#863) Ordered filters alphabetically in English and French documentation. Chinese docs only have references to Jinja docs, so are not updated. Closes mozilla#858 added more elaborate tests and adding variants of values that can be passed in json remove single quotes and added spaces here and there change foo dump to items dump consistency change key types correcting documentation dump filter perfecting dump documentation perfecting dump testing added different indentation complete tests
JesseE
force-pushed
the
feat/dump-filter-spaces
branch
from
040e590
to
fd18076
Compare
… in docs/templating.md
|
@JesseE looks good to me! I'd like to get this change in. The added filesize is neglectable (so doesn't hurt browser use). @vecmezoni do you agree? |
|
Thank you! |
Summary
Proposed change:
Nunjucks has a convenient
dumpfilter which stringifies JSON. But the output is a hard to read string.This PR proposes a change to the
dumpfilter to accept an optionalspaceargument and pass that through toJSON.stringify(input, null, space). You can use|dump(2)or|dump('\t')which gives much more meaningful output.closes #867
Checklist
I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.