Skip to content

Commit

Permalink
Merge pull request #18069 from Snuffleupagus/rm-spaceWidth
Browse files Browse the repository at this point in the history
Remove the unused `Font.prototype.spaceWidth` getter (PR 13424 follow-up)
  • Loading branch information
timvandermeij authored May 13, 2024
2 parents 1c25e95 + 4aee672 commit d9cff1a
Showing 1 changed file with 0 additions and 38 deletions.
38 changes: 0 additions & 38 deletions src/core/fonts.js
Original file line number Diff line number Diff line change
Expand Up @@ -3289,44 +3289,6 @@ class Font {
return builder.toArray();
}

get spaceWidth() {
// trying to estimate space character width
const possibleSpaceReplacements = ["space", "minus", "one", "i", "I"];
let width;
for (const glyphName of possibleSpaceReplacements) {
// if possible, getting width by glyph name
if (glyphName in this.widths) {
width = this.widths[glyphName];
break;
}
const glyphsUnicodeMap = getGlyphsUnicode();
const glyphUnicode = glyphsUnicodeMap[glyphName];
// finding the charcode via unicodeToCID map
let charcode = 0;
if (this.composite && this.cMap.contains(glyphUnicode)) {
charcode = this.cMap.lookup(glyphUnicode);

if (typeof charcode === "string") {
charcode = convertCidString(glyphUnicode, charcode);
}
}
// ... via toUnicode map
if (!charcode && this.toUnicode) {
charcode = this.toUnicode.charCodeOf(glyphUnicode);
}
// setting it to unicode if negative or undefined
if (charcode <= 0) {
charcode = glyphUnicode;
}
// trying to get width via charcode
width = this.widths[charcode];
if (width) {
break; // the non-zero width found
}
}
return shadow(this, "spaceWidth", width || this.defaultWidth);
}

/**
* @private
*/
Expand Down

0 comments on commit d9cff1a

Please sign in to comment.