Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused Font.prototype.spaceWidth getter (PR 13424 follow-up) #18069

Merged
merged 1 commit into from
May 13, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This getter became unused in PR #13424, well over two years ago, and apparently none of us noticed that.

…-up)

This getter became unused in PR 13424, well over two years ago, and apparently none of us noticed that.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5e4ab7329d68d83/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/5e4ab7329d68d83/output.txt

Total script time: 27.44 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 17
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/5e4ab7329d68d83/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit d9cff1a into mozilla:master May 13, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Thank you for cleaning this up!

@Snuffleupagus Snuffleupagus deleted the rm-spaceWidth branch May 13, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants