[Bug]: Hebrew filePaths not working

[ToratEmetInWord]

Attach (recommended) or Link to PDF file

הגדה של פסח מדרש הגדה להמלבים.pdf

Web browser and its version

all browsers

Operating system and its version

windows 10 latest

PDF.js version

latest

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

1. use this code in linqpad 5

class Program
{
    static TaskCompletionSource<bool> serverLoaded = new TaskCompletionSource<bool>();
    
    static async Task Main()
    {
        // URL and base directory for the local server
        string url = "http://localhost:8082/";
        string baseDirectory = @"C:\Users\Admin\Downloads\pdfjs-4.7.76-legacy-dist\web";

        // Start the server in a separate task
        Task serverTask = Task.Run(() => StartServer(url, baseDirectory));

        // Wait for the server to start
        Console.WriteLine("Starting server...");
        await serverLoaded.Task; // Wait for the server to signal it's started
		
        // Access the server after it has started
        await AccessServerAsync(url);
        
        // Optionally wait for the server task to finish (which won't happen in this case)
        // await serverTask;
    }

    // Method to start the server
    static void StartServer(string url, string baseDirectory)
    {
        using (var listener = new HttpListener())
        {
            listener.Prefixes.Add(url);
            listener.Start();
            Console.WriteLine($"Listening on {url}");
            
            serverLoaded.SetResult(true); // Signal that the server has started
            
            while (true)
            {
                // Listen for an incoming request
                HttpListenerContext context = listener.GetContext();
                HttpListenerRequest request = context.Request;
                HttpListenerResponse response = context.Response;

                // Handle requested file or query
                string requestedFile = request.Url.AbsolutePath.TrimStart('/');
                string fileQuery = request.QueryString["file"];

                if (!string.IsNullOrEmpty(fileQuery))
                {
                    requestedFile = fileQuery;
                }
                else if (string.IsNullOrEmpty(requestedFile))
                {
                    requestedFile = "viewer.html"; // Default file
                }

                // Get the full file path
                string filePath = Path.IsPathRooted(requestedFile)
                    ? requestedFile
                    : Path.Combine(baseDirectory, requestedFile);

                // Serve the requested file or return 404
                if (File.Exists(filePath))
                {
                    string contentType = GetContentType(filePath);
                    response.ContentType = contentType;

                    byte[] buffer = File.ReadAllBytes(filePath);
                    response.ContentLength64 = buffer.Length;

                    using (var output = response.OutputStream)
                    {
                        output.Write(buffer, 0, buffer.Length);
                    }
                }
                else
                {
                    response.StatusCode = (int)HttpStatusCode.NotFound;
                    byte[] errorMessage = System.Text.Encoding.UTF8.GetBytes("404 - File Not Found");
                    response.ContentLength64 = errorMessage.Length;
                    response.ContentType = "text/plain";
                    using (var output = response.OutputStream)
                    {
                        output.Write(errorMessage, 0, errorMessage.Length);
                    }
                }
            }
        }
    }

    // Method to access the local server after it's started
    static async Task AccessServerAsync(string url)
    {
        using (var client = new HttpClient())
        {
			string encodedFilePath = Uri.EscapeDataString(""); //insert path to pdf here
			Console.WriteLine(encodedFilePath);
			
            try
            {
 				System.Diagnostics.Process.Start(url + "viewer.html?file=" + encodedFilePath);
            }
            catch (Exception ex)
            {
                Console.WriteLine($"Error accessing server: {ex.Message}");
            }
        }
    }

    // Method to get the content type based on the file extension
    static string GetContentType(string filePath)
    {
        string extension = Path.GetExtension(filePath).ToLower();
        switch (extension)
        {
            case ".html":
                return "text/html";
            case ".css":
                return "text/css";
            case ".js":
                return "application/javascript";
            case ".png":
                return "image/png";
            case ".jpg":
            case ".jpeg":
                return "image/jpeg";
            case ".gif":
                return "image/gif";
            case ".svg":
                return "image/svg+xml";
            case ".pdf":
                return "application/pdf";
            default:
                return "application/octet-stream";
        }
    }
}

What is the expected behavior?

pdf should load however only english filepaths are loaded not hebrew

What went wrong?

error 404 file not found

Link to a viewer

No response

Additional context

No response

[ToratEmetInWord]

turns out the problem was in my code i needed to decoed the filepath using utf8

here is the working code:

class Program
{
    static TaskCompletionSource<bool> serverLoaded = new TaskCompletionSource<bool>();
    
    static async Task Main()
    {
        // URL and base directory for the local server
        string url = "http://localhost:8082/";
        string baseDirectory = @"C:\Users\Admin\Downloads\pdfjs-4.7.76-legacy-dist\web";

        // Start the server in a separate task
        Task serverTask = Task.Run(() => StartServer(url, baseDirectory));

        // Wait for the server to start
        Console.WriteLine("Starting server...");
        await serverLoaded.Task; // Wait for the server to signal it's started
		
        // Access the server after it has started
        await AccessServerAsync(url);
        
        // Optionally wait for the server task to finish (which won't happen in this case)
        // await serverTask;
    }

    // Method to start the server
    static void StartServer(string url, string baseDirectory)
    {
        using (var listener = new HttpListener())
        {
            listener.Prefixes.Add(url);
            listener.Start();
            Console.WriteLine($"Listening on {url}");
            
            serverLoaded.SetResult(true); // Signal that the server has started
            
            while (listener.IsListening)
            {
                // Listen for an incoming request
                HttpListenerContext context = listener.GetContext();
                HttpListenerRequest request = context.Request;
                HttpListenerResponse response = context.Response;

                // Handle requested file or query
                string requestedFile = request.Url.AbsolutePath.TrimStart('/');
                string fileQuery = request.QueryString["file"];

                if (!string.IsNullOrEmpty(fileQuery))
                {
                    // Decode the file query using UTF-8 encoding to handle Hebrew or other special characters
                    requestedFile = Encoding.UTF8.GetString(Encoding.Default.GetBytes(Uri.UnescapeDataString(fileQuery)));
                    Console.WriteLine("Decoded file query:" + requestedFile); // Debugging line
                }
                else if (string.IsNullOrEmpty(requestedFile))
                {
                    requestedFile = "viewer.html"; // Default file
                }

                // Get the full file path
                string filePath = Path.IsPathRooted(requestedFile)
                    ? requestedFile
                    : Path.Combine(baseDirectory, requestedFile);

                Console.WriteLine($"Requested file path: {filePath}"); // Debugging line

                // Serve the requested file or return 404
                if (File.Exists(filePath))
                {
                    string contentType = GetContentType(filePath);
                    response.ContentType = contentType;

                    byte[] buffer = File.ReadAllBytes(filePath);
                    response.ContentLength64 = buffer.Length;

                    using (var output = response.OutputStream)
                    {
                        output.Write(buffer, 0, buffer.Length);
                    }
                }
                else
                {
                    response.StatusCode = (int)HttpStatusCode.NotFound;
                    byte[] errorMessage = Encoding.UTF8.GetBytes("404 - File Not Found");
                    response.ContentLength64 = errorMessage.Length;
                    response.ContentType = "text/plain";
                    using (var output = response.OutputStream)
                    {
                        output.Write(errorMessage, 0, errorMessage.Length);
                    }
                }
            }
        }
    }

    // Method to access the local server after it's started
    static async Task AccessServerAsync(string url)
    {
        using (var client = new HttpClient())
        {
			// Hebrew file path
			string filePath = "הגדה.pdf"; 
			
			// Encode the file path using UTF-8 encoding to properly handle non-ASCII characters
			string encodedFilePath = Uri.EscapeDataString(filePath);
			Console.WriteLine($"Encoded file path: {encodedFilePath}"); // Debugging line
			
            try
            {
 				// Start browser with the encoded file path
 				System.Diagnostics.Process.Start(url + "viewer.html?file=" + encodedFilePath);
            }
            catch (Exception ex)
            {
                Console.WriteLine($"Error accessing server: {ex.Message}");
            }
        }
    }

    // Method to get the content type based on the file extension
    static string GetContentType(string filePath)
    {
        string extension = Path.GetExtension(filePath).ToLower();
        switch (extension)
        {
            case ".html":
                return "text/html";
            case ".css":
                return "text/css";
            case ".js":
                return "application/javascript";
            case ".png":
                return "image/png";
            case ".jpg":
            case ".jpeg":
                return "image/jpeg";
            case ".gif":
                return "image/gif";
            case ".svg":
                return "image/svg+xml";
            case ".pdf":
                return "application/pdf";
            default:
                return "application/octet-stream";
        }
    }
}