Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF Annotations made in iOS do not render properly #11306

Closed
mxiao6 opened this issue Nov 4, 2019 · 2 comments · Fixed by #18204
Closed

PDF Annotations made in iOS do not render properly #11306

mxiao6 opened this issue Nov 4, 2019 · 2 comments · Fixed by #18204
Labels
core image-conversion image-jpx

Comments

@mxiao6
Copy link

mxiao6 commented Nov 4, 2019

Attach (recommended) or Link to PDF file here:
2018 Wrapped.pdf

Configuration:

  • Web browser and its version: Chrome 78.0.3904.70 (Official Build) (64-bit)
  • Operating system and its version: MacOS 10.14.6
  • PDF.js version: v2.2.228 and the latest version in PDF.js demo (https://mozilla.github.io/pdf.js/web/viewer.html)
  • Is a browser extension: No

Steps to reproduce the problem:

  1. Annotate PDF on iOS
  2. Open it with PDF.js (https://mozilla.github.io/pdf.js/web/viewer.html)

What is the expected behavior? (add screenshot)
image

What went wrong? (add screenshot)
image (1)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
@timvandermeij
Copy link
Contributor

I also have this problem with the most recent development viewer. The first page only contains Link annotations, which render fine, and a Square annotation with an image in the appearance stream. The latter is rendered incorrectly like this, presumably because of the warning Warning: Unsupported header type 1667523942 (cdef) in the console.

@bkirkby
Copy link

bkirkby commented Dec 2, 2019

here is another document with the problem image conversion from macos. our support team thinks they narrowed it down to the creation of the annotations being on iOS 13 with it's Markup tool.

iOS+Mark+Ups2.pdf

@Snuffleupagus Snuffleupagus mentioned this issue Oct 11, 2022
Closed
@Snuffleupagus Snuffleupagus linked a pull request Jun 3, 2024 that will close this issue
Fix decoding of JPX images having an alpha channel #18204
Merged
jollaitbot pushed a commit to sailfishos-mirror/poppler that referenced this issue Nov 11, 2024
@nbenitez @tsdgeos
cairo: Fix rendering of JPX images with transparency
69da0db 
Handle transparent JPX images, they may contain RGBA data
when no ColorSpace pdf dict is defined or when SMaskInData
is non-zero.

PDF files posted in below issues are fixed by this commit:
https://gitlab.freedesktop.org/poppler/poppler/-/issues/1486
mozilla/pdf.js#16782
mozilla/pdf.js#11306
mozilla/pdf.js#17416

Inspired by related fix in pdf.js:
mozilla/pdf.js#18204

While working on this commit we also succesfully addressed
regressions that emerged for the following files:
mozilla/pdf.js#18896
https://bugs.freedesktop.org/attachment.cgi?id=49294

Issue #1486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core image-conversion image-jpx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix decoding of JPX images having an alpha channel calixteman/pdf.js
4 participants
@bkirkby @timvandermeij @Snuffleupagus @mxiao6