-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decoding of JPX images having an alpha channel #18204
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d0917ce728a316f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6e11bb66521501b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d0917ce728a316f/output.txt Total script time: 28.29 mins
Image differences available at: http://54.241.84.105:8877/d0917ce728a316f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6e11bb66521501b/output.txt Total script time: 43.58 mins
Image differences available at: http://54.193.163.58:8877/6e11bb66521501b/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with a couple of nits; thank you!
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/359d4e88db737e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a963b4b79f4a32f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/359d4e88db737e0/output.txt Total script time: 28.02 mins
Image differences available at: http://54.241.84.105:8877/359d4e88db737e0/reftest-analyzer.html#web=eq.log |
I think there a regression in With that addressed this patch also LGTM; thank you for fixing this issue! |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a963b4b79f4a32f/output.txt Total script time: 43.25 mins
Image differences available at: http://54.193.163.58:8877/a963b4b79f4a32f/reftest-analyzer.html#web=eq.log |
When an image has a non-zero SMaskInData it means that the image has an alpha channel. With JPX images, the colorspace isn't required (by spec) so when we don't have it, the JPX decoder will handle the conversion in RGBA format.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/431f00638cfc18a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e79df2894c62088/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/431f00638cfc18a/output.txt Total script time: 28.14 mins
Image differences available at: http://54.241.84.105:8877/431f00638cfc18a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e79df2894c62088/output.txt Total script time: 42.91 mins
Image differences available at: http://54.193.163.58:8877/e79df2894c62088/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fe3c6903b42bbf3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0d236a4599ad1ad/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fe3c6903b42bbf3/output.txt Total script time: 19.32 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0d236a4599ad1ad/output.txt Total script time: 24.15 mins
|
Handle transparent JPX images, they may contain RGBA data when no ColorSpace pdf dict is defined or when SMaskInData is non-zero. PDF files posted in below issues are fixed by this commit: https://gitlab.freedesktop.org/poppler/poppler/-/issues/1486 mozilla/pdf.js#16782 mozilla/pdf.js#11306 mozilla/pdf.js#17416 Inspired by related fix in pdf.js: mozilla/pdf.js#18204 While working on this commit we also succesfully addressed regressions that emerged for the following files: mozilla/pdf.js#18896 https://bugs.freedesktop.org/attachment.cgi?id=49294 Issue #1486
When an image has a non-zero SMaskInData it means that the image has an alpha channel.
With JPX images, the colorspace isn't required (by spec) so when we don't have it, the JPX decoder will handle the conversion in RGBA format.