Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<input> elements for annotations inherit some style from viewer.css #14736

Closed
calixteman opened this issue Mar 31, 2022 · 1 comment · Fixed by #14936
Closed

<input> elements for annotations inherit some style from viewer.css #14736

calixteman opened this issue Mar 31, 2022 · 1 comment · Fixed by #14936
Labels
form-acroform

Comments

@calixteman
Copy link
Contributor

calixteman commented Mar 31, 2022 •
edited
Loading

STR:

According to:
https://developer.mozilla.org/en-US/docs/Web/CSS/font#message-box
this value is for dialog boxes so I think it doesn't make sense to use it for annotation.
@salmanansari14
Copy link

can u please assign me this issue !!

@Snuffleupagus Snuffleupagus mentioned this issue May 19, 2022
Merged
@calixteman calixteman linked a pull request May 20, 2022 that will close this issue
Set the text fields font size based on their height #14936
Merged
calixteman added a commit to calixteman/pdf.js that referenced this issue May 20, 2022
@calixteman
Set the text fields font size based on their height
d32dbb9 
- right now we're using the font size from the pdf itself but we use an other font
  in the annotation layer. So this size doesn't really make sense and leads to bad
  rendering (see pdf in mozilla#14928);
- use a sans-serif font for the fields containing text (fix issue mozilla#14736);
- remove useless padding in text-based fields (fix issue mozilla#14301);
- text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
  value to hide/show scrollbars in annotation layer.
calixteman added a commit to calixteman/pdf.js that referenced this issue May 20, 2022
@calixteman
Set the text fields font size based on their height
c5a64db 
- right now we're using the font size from the pdf itself but we use an other font
  in the annotation layer. So this size doesn't really make sense and leads to bad
  rendering (see pdf in mozilla#14928);
- use a sans-serif font for the fields containing text (fix issue mozilla#14736);
- remove useless padding in text-based fields (fix issue mozilla#14301);
- text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
  value to hide/show scrollbars in annotation layer.
calixteman added a commit to calixteman/pdf.js that referenced this issue May 20, 2022
@calixteman
Set the text fields font size based on their height
52aa598 
- right now we're using the font size from the pdf itself but we use an other font
  in the annotation layer. So this size doesn't really make sense and leads to bad
  rendering (see pdf in mozilla#14928);
- use a sans-serif font for the fields containing text (fix issue mozilla#14736);
- remove useless padding in text-based fields (fix issue mozilla#14301);
- text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
  value to hide/show scrollbars in annotation layer.
calixteman added a commit to calixteman/pdf.js that referenced this issue May 28, 2022
@calixteman
Set the text fields font size based on their height
12dd4ac 
- right now we're using the font size from the pdf itself but we use an other font
  in the annotation layer. So this size doesn't really make sense and leads to bad
  rendering (see pdf in mozilla#14928);
- use a sans-serif font for the fields containing text (fix issue mozilla#14736);
- remove useless padding in text-based fields (fix issue mozilla#14301);
- text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
  value to hide/show scrollbars in annotation layer.
calixteman added a commit to calixteman/pdf.js that referenced this issue May 28, 2022
@calixteman
Set the text fields font size based on their height
9d82106 
- right now we're using the font size from the pdf itself but we use an other font
  in the annotation layer. So this size doesn't really make sense and leads to bad
  rendering (see pdf in mozilla#14928);
- use a sans-serif font for the fields containing text (fix issue mozilla#14736);
- remove useless padding in text-based fields (fix issue mozilla#14301);
- text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
  value to hide/show scrollbars in annotation layer.
bh213 pushed a commit to bh213/pdf.js that referenced this issue Jun 3, 2022
@calixteman @bh213
Set the text fields font size based on their height
a435a02 
- right now we're using the font size from the pdf itself but we use an other font
  in the annotation layer. So this size doesn't really make sense and leads to bad
  rendering (see pdf in mozilla#14928);
- use a sans-serif font for the fields containing text (fix issue mozilla#14736);
- remove useless padding in text-based fields (fix issue mozilla#14301);
- text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
  value to hide/show scrollbars in annotation layer.
rousek pushed a commit to signosoft/pdf.js that referenced this issue Aug 10, 2022
@calixteman @rousek
Set the text fields font size based on their height
807b2e5 
- right now we're using the font size from the pdf itself but we use an other font
  in the annotation layer. So this size doesn't really make sense and leads to bad
  rendering (see pdf in mozilla#14928);
- use a sans-serif font for the fields containing text (fix issue mozilla#14736);
- remove useless padding in text-based fields (fix issue mozilla#14301);
- text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
  value to hide/show scrollbars in annotation layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
form-acroform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set the text fields font size based on their height calixteman/pdf.js
2 participants
@calixteman @salmanansari14