Set the text fields font size based on their height #14936

calixteman · 2022-05-19T13:21:56Z

right now we're using the font size from the pdf itself but we use an other font
in the annotation layer. So this size doesn't really make sense and leads to bad
rendering (see pdf in [annotation] Text widget background color is not taken into account when printed #14928);
use a sans-serif font for the fields containing text;
text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this
value to hide/show scrollbars in annotation layer.

Snuffleupagus · 2022-05-19T13:36:19Z

src/display/annotation_layer.js

+    // We don't use in the input the font which is in the pdf, so
+    // using the fontSize can lead to bad display.
+    // Hence, we set the fontSize in based on the field height.


Let's improve the grammar a little bit here, e.g. like so:

// We don't use the font, as specified in the PDF document, for the <input> // element. Hence using the original `fontSize` could look bad, which is why // it's instead based on the field height.

Snuffleupagus · 2022-05-19T13:36:46Z

src/shared/util.js

@@ -18,6 +18,11 @@ import "./compatibility.js";
 const IDENTITY_MATRIX = [1, 0, 0, 1, 0, 0];
 const FONT_IDENTITY_MATRIX = [0.001, 0, 0, 0.001, 0, 0];

+// Represent the percentage of the height of a single-line field over
+// the font size.
+// Acrobat seems to use this value.


Nit: Can be moved to the previous line.

Snuffleupagus · 2022-05-19T13:38:39Z

web/annotation_layer_builder.css

@@ -59,10 +59,9 @@
  background-image: var(--annotation-unfocused-field-background);
  border: 1px solid transparent;
  box-sizing: border-box;
-  font-size: 9px;
+  font: 9px sans-serif;


Is this essentially "sneaking" in a fix for issue #14736 here?

If so, that's probably good to mention explicitly in the commit message (and linking the issue such that it's closed).

Snuffleupagus · 2022-05-19T13:42:11Z

web/annotation_layer_builder.css

  height: 100%;
  margin: 0;
-  padding: 0 3px;


Is this essentially "sneaking" in a fix for issue #14301 here?

If so, that's probably good to mention explicitly in the commit message (and linking the issue such that it's closed).

Given the discussion in the issue, does this generally work without problems?
Is this properly covered by existing tests, or does new reference test(s) need to be added?

calixteman · 2022-05-20T15:40:36Z

/botio test

pdfjsbot · 2022-05-20T15:41:00Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5b8a9612200a823/output.txt

pdfjsbot · 2022-05-20T15:41:00Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/17a3ca8a91f3fef/output.txt

pdfjsbot · 2022-05-20T16:08:08Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5b8a9612200a823/output.txt

Total script time: 27.11 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 52

Image differences available at: http://54.241.84.105:8877/5b8a9612200a823/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-05-20T16:10:38Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/17a3ca8a91f3fef/output.txt

Total script time: 29.61 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 22

Image differences available at: http://54.193.163.58:8877/17a3ca8a91f3fef/reftest-analyzer.html#web=eq.log

calixteman · 2022-05-20T16:46:22Z

/botio test

pdfjsbot · 2022-05-20T16:46:25Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/45c80418c2cccaa/output.txt

pdfjsbot · 2022-05-20T16:46:25Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8157e09d3166735/output.txt

pdfjsbot · 2022-05-20T17:05:55Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/45c80418c2cccaa/output.txt

Total script time: 19.48 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 709
  different ref/snapshot: 21

Image differences available at: http://54.241.84.105:8877/45c80418c2cccaa/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-05-20T17:14:10Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8157e09d3166735/output.txt

Total script time: 27.73 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 14

Image differences available at: http://54.193.163.58:8877/8157e09d3166735/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2022-05-20T18:05:59Z

It seems that a border in issue13447-annotations-page1 is now missing, was that intended?
There are some missing borders in issue12716-page1 and issue12716-hidpi-page1, which I'm guessing isn't intended?

calixteman · 2022-05-20T18:22:03Z

About:

issue13447-annotations-page1: in Acrobat there are no yellow border around the icon and and in specs, in Table 164, the C entry is used here for "The title bar of the annotation’s pop-up window". The C entry is only used as the border color for the Link annotation.
issue12716-page1 there is a very small text field with dimensions 0.025in x 0.025in, before the patch it looks rectangular

and with the patch it looks like a square

and it's likely due to the padding change

calixteman · 2022-05-28T14:53:27Z

/botio test

pdfjsbot · 2022-05-28T14:53:28Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/fb19329172665ce/output.txt

pdfjsbot · 2022-05-28T14:53:29Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/1f1126e3bb423ec/output.txt

pdfjsbot · 2022-05-28T15:20:21Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fb19329172665ce/output.txt

Total script time: 25.93 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 52

Image differences available at: http://54.241.84.105:8877/fb19329172665ce/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-05-28T15:25:57Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/1f1126e3bb423ec/output.txt

Total script time: 28.15 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 14

Image differences available at: http://54.193.163.58:8877/1f1126e3bb423ec/reftest-analyzer.html#web=eq.log

Snuffleupagus

Unless I'm overlooking something, I don't believe that the following override is necessary now:

pdf.js/web/annotation_layer_builder.css

Line 170 in d80035b

padding: 0;

r=me, with the above fixed since this looks overall reasonable to me; thank you!

- right now we're using the font size from the pdf itself but we use an other font in the annotation layer. So this size doesn't really make sense and leads to bad rendering (see pdf in mozilla#14928); - use a sans-serif font for the fields containing text (fix issue mozilla#14736); - remove useless padding in text-based fields (fix issue mozilla#14301); - text fields allow/disallow scrolling bars (see bit 24 in Ff entry), so use this value to hide/show scrollbars in annotation layer.

calixteman · 2022-05-28T16:01:21Z

/botio test

pdfjsbot · 2022-05-28T16:01:23Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30ebe9859ac825f/output.txt

pdfjsbot · 2022-05-28T16:01:23Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b5e56710e3a4703/output.txt

pdfjsbot · 2022-05-28T16:27:29Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/30ebe9859ac825f/output.txt

Total script time: 26.10 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 51

Image differences available at: http://54.241.84.105:8877/30ebe9859ac825f/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-05-28T16:29:26Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b5e56710e3a4703/output.txt

Total script time: 28.04 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 14

Image differences available at: http://54.193.163.58:8877/b5e56710e3a4703/reftest-analyzer.html#web=eq.log

calixteman · 2022-05-28T16:32:55Z

/botio makeref

pdfjsbot · 2022-05-28T16:32:57Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/3c9f771ca4dcdaa/output.txt

pdfjsbot · 2022-05-28T16:32:57Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/39b0d65d21af1af/output.txt

pdfjsbot · 2022-05-28T16:55:43Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/39b0d65d21af1af/output.txt

Total script time: 22.75 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2022-05-28T16:57:54Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/3c9f771ca4dcdaa/output.txt

Total script time: 21.78 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman added the form-acroform label May 19, 2022

calixteman requested a review from Snuffleupagus May 19, 2022 13:21

Snuffleupagus reviewed May 19, 2022

View reviewed changes

This was linked to issues May 20, 2022

<input> elements for annotations inherit some style from viewer.css #14736

Closed

Content in some text widgets are not visible #14301

Closed

calixteman force-pushed the input_font_size branch from 7f68aed to d32dbb9 Compare May 20, 2022 15:40

calixteman force-pushed the input_font_size branch 2 times, most recently from c5a64db to 52aa598 Compare May 20, 2022 16:44

calixteman force-pushed the input_font_size branch from 52aa598 to 12dd4ac Compare May 28, 2022 14:41

Snuffleupagus approved these changes May 28, 2022

View reviewed changes

calixteman force-pushed the input_font_size branch from 12dd4ac to 9d82106 Compare May 28, 2022 16:00

calixteman merged commit 9bdf27e into mozilla:master May 28, 2022

ZeroXClem mentioned this pull request Aug 12, 2024

[Snyk] Upgrade pdfjs-dist from 2.9.359 to 2.16.105 ZeroXClem/metamesa#3

Closed

earthywh mentioned this pull request Sep 24, 2024

[Snyk] Upgrade pdfjs-dist from 2.6.347 to 2.16.105 earthywh/filestash#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set the text fields font size based on their height #14936

Set the text fields font size based on their height #14936

calixteman commented May 19, 2022

Snuffleupagus May 19, 2022

Snuffleupagus May 19, 2022

Snuffleupagus May 19, 2022

Snuffleupagus May 19, 2022

calixteman commented May 20, 2022

pdfjsbot commented May 20, 2022

pdfjsbot commented May 20, 2022

pdfjsbot commented May 20, 2022

pdfjsbot commented May 20, 2022

calixteman commented May 20, 2022

pdfjsbot commented May 20, 2022

pdfjsbot commented May 20, 2022

pdfjsbot commented May 20, 2022

pdfjsbot commented May 20, 2022

Snuffleupagus commented May 20, 2022 •

edited

Loading

calixteman commented May 20, 2022

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

Snuffleupagus left a comment

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

pdfjsbot commented May 28, 2022

Set the text fields font size based on their height #14936

Set the text fields font size based on their height #14936

Conversation

calixteman commented May 19, 2022

Snuffleupagus May 19, 2022

Choose a reason for hiding this comment

Snuffleupagus May 19, 2022

Choose a reason for hiding this comment

Snuffleupagus May 19, 2022

Choose a reason for hiding this comment

Snuffleupagus May 19, 2022

Choose a reason for hiding this comment

calixteman commented May 20, 2022

pdfjsbot commented May 20, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 20, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Failed

calixteman commented May 20, 2022

pdfjsbot commented May 20, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 20, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 20, 2022

From: Bot.io (Windows)

Failed

Snuffleupagus commented May 20, 2022 • edited Loading

calixteman commented May 20, 2022

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Failed

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Failed

calixteman commented May 28, 2022

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented May 28, 2022

From: Bot.io (Linux m4)

Success

pdfjsbot commented May 28, 2022

From: Bot.io (Windows)

Snuffleupagus commented May 20, 2022 •

edited

Loading