-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify our css in using :is or :where #16194
Comments
Do you have any examples of CSS rules that would benefit from such a re-factoring? Also, please note that this would require bumping the minimum supported Google Chrome version; see #16192 (comment). |
For example: Line 330 in f39ff20
Probably few others for annotations. I didn't know either :is or :where before today. |
Assign this issue to me I will simplify viewer.css |
Sorry, but this may not be an ideal beginner bug without any prior PDF.js experience (given that any changes require careful manual testing). Furthermore, as outlined in #16194 (comment) this potentially applies to all our CSS-files (and not just one). |
Once all of the PRs linked above are merged, I think that it'll be reasonable to consider this issue fixed :-) |
For reference:
The text was updated successfully, but these errors were encountered: