Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify our css in using :is or :where #16194

Closed
calixteman opened this issue Mar 22, 2023 · 5 comments · Fixed by #16192, #16310, #16313, #16314 or #16315
Closed

Simplify our css in using :is or :where #16194

calixteman opened this issue Mar 22, 2023 · 5 comments · Fixed by #16192, #16310, #16313, #16314 or #16315
Assignees
Labels

Comments

@calixteman
Copy link
Contributor

For reference:

@Snuffleupagus
Copy link
Collaborator

Do you have any examples of CSS rules that would benefit from such a re-factoring?

Also, please note that this would require bumping the minimum supported Google Chrome version; see #16192 (comment).

@calixteman
Copy link
Contributor Author

For example:

.toolbar input,

Probably few others for annotations.

I didn't know either :is or :where before today.

@tymnec
Copy link

tymnec commented Apr 2, 2023

Assign this issue to me I will simplify viewer.css

@Snuffleupagus
Copy link
Collaborator

Sorry, but this may not be an ideal beginner bug without any prior PDF.js experience (given that any changes require careful manual testing). Furthermore, as outlined in #16194 (comment) this potentially applies to all our CSS-files (and not just one).

@Snuffleupagus
Copy link
Collaborator

Once all of the PRs linked above are merged, I think that it'll be reasonable to consider this issue fixed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment