Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce some :is usage in the xfaLayer CSS #16310

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Hopefully these changes make sense (since this functionality is new to me), however the existing xfa-tests should help avoid any outright regressions.

Hopefully these changes make sense (since this functionality is new to me), however the existing `xfa`-tests should help avoid any outright regressions.
@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/409bb4283af9359/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/770a2ef8e50bf6f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/409bb4283af9359/output.txt

Total script time: 10.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/409bb4283af9359/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/770a2ef8e50bf6f/output.txt

Total script time: 11.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/770a2ef8e50bf6f/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit f98358a into mozilla:master Apr 19, 2023
@Snuffleupagus Snuffleupagus deleted the xfaLayer-CSS-is branch April 19, 2023 13:15
@Snuffleupagus Snuffleupagus linked an issue Apr 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify our css in using :is or :where
3 participants