[Bug]: find highlight matches wrong index with normalization for compound word with a line break after the hyphen. #19120
Assignees
Labels
Comments
|
Is this perhaps a regression from PR #18730, since #18693 (comment) mentions that fixing that one could lead to other issues? |
calixteman
added a commit
to calixteman/pdf.js
that referenced
this issue
Nov 28, 2024
…t contains a compound word on two lines It fixes mozilla#19120. The original text doesn't contain the cr so we must take that into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Attach (recommended) or Link to PDF file
compound_word_with_line_break_after_hyphen.pdf
Web browser and its version
Firefox 133
Operating system and its version
Windows 10
PDF.js version
v4.8.69
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem
What is the expected behavior?
The letter "o" should be highlighted
What went wrong?
Because of the normalization the index is off by 1 and the letter "n" is highlighted
The span for the highlight contains only the letter "n" instead of "o"
Link to a viewer
No response
Additional context
It seems that during normalization in pdf_find_controller.js the position calculated for the case "Compound word with a line break after the hyphen." is wrong.
The text was updated successfully, but these errors were encountered: