-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using the hand tool, sometimes the secondary tool bar will go behind the document #5452
Comments
I have personally never seen that happen before. Could this be a |
The effect can be reproduced in Chromium 38.0.2125.106 as follows (though I'm not certain whether the cause is the same):
Observe that at step 4, the menu goes behind the canvas. And after a while, the menu simply disappears. In Firefox, the menu always stays open. |
I should also have noted I'm in Win7 64b using pdfjs 1.0.473 ( and recently tried 1.0.712 as well ). This happened most often in IE11, but also was able to make it happen in FF33. I've noticed now that if I follow the steps above, and drag the document ( with hand tool enabled BUT scrolling with the scrollbar instead of the hand ) this reproduces it every time in IE11. In FF33 this makes it go behind temporarily but it comes back to the front as soon as I stop scrolling. |
Is this still an issue? |
I can still reproduce using the STR from #5452 (comment) in Chromium 80.0.3987.132. The menu goes behind the canvas, but doesn't completely disappear though. |
…sToolbar to resolve toolbars going behind canvas issue (bug 5452). While my fix was targeted toward the secondaryToolbar, I noticed that the issue regarding the toolbars going behind the canvas on using the hand tool persisted for the findToolbar as well. So to fix I just updated their common z-index value to be just higher than the screen grabbing div's z-index. Issue seems to be resolved in both Chrome,Brave and Firefox. This is a fix for mozilla#5452
…sToolbar to resolve toolbars going behind canvas issue (bug 5452). While my fix was targeted toward the secondaryToolbar, I noticed that the issue regarding the toolbars going behind the canvas on using the hand tool persisted for the findToolbar as well. So to fix I just reduced the z-index of the .grab-to-pan-grabbing class to 29000 and updated its comment accordingly. I tested the fix extensively in Chrome, Firefox and Brave and it seems to be fixed. This is a fix for mozilla#5452
… going behind canvas issue (bug 5452). While my fix was targeted toward the secondaryToolbar, I noticed that the issue regarding the toolbars going behind the canvas on using the hand tool persisted for the findToolbar as well. So to fix I just reduced the z-index of the .grab-to-pan-grabbing class to 29000 and updated its comment accordingly. I tested the fix extensively in Chrome, Firefox and Brave and it seems to be fixed. This is a fix for mozilla#5452
Win7 64b ( tried using pdfjs 1.0.473 and 1.0.712 )
To reproduce I simply use the hand tool and scroll pages with it for a bit, and then click on the button to open the secondary menu. Sometimes when I do this it gets stuck behind the document. When this happens a page refresh is required to fix it. This doesn't happen every time so reproducing it is somewhat awkward. IE11 reproduces with a higher frequency, although I was also able to reproduce in FF32 as well:
The text was updated successfully, but these errors were encountered: