Drop redundant styles from .grab-to-pan-grab:active #16896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.grab-to-pan-grab:active` is `#viewerContainer` when the mouse is pressed down. It is supposed to have a `cursor: grabbing` appearance immediately on mousedown, `.grab-to-pan-grabbing` is the overlay that is supposed to cover everything, and also has the `cursor: grabbing` appearance. The "cover everything" result is achieved through `position:fixed`, `inset:0`, etc. The block with these CSS properties for "cover everything" is currently shared by `.grab-to-pan-grab:active` and `.grab-to-pan-grabbing`, but only "cursor" need to be shared. The original JS and CSS code at https://github.com/Rob--W/grab-to-pan.js shows that these were supposed to be associated with the overlay only. The PR that added this to PDF.js also shows that the "cover everything" CSS properties were supposed to be limited to the overlay only: mozilla#4209 (diff) But the final version of the PR mistakenly merged them together. This patch rectifies that mistake.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e7ec5ce9ff3caa4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e7ec5ce9ff3caa4/output.txt Total script time: 1.46 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.grab-to-pan-grab:activeis#viewerContainerwhen the mouse is pressed down. It is supposed to have acursor: grabbingappearance immediately on mousedown,.grab-to-pan-grabbingis the overlay that is supposed to cover everything, and also has thecursor: grabbingappearance. The "cover everything" result is achieved throughposition:fixed,inset:0, etc.The block with these CSS properties for "cover everything" is currently shared by
.grab-to-pan-grab:activeand.grab-to-pan-grabbing, but only "cursor" need to be shared. The original JS and CSS code at https://github.com/Rob--W/grab-to-pan.js shows that these were supposed to be associated with the overlay only.The PR that added this to PDF.js also shows that the "cover everything" CSS properties were supposed to be limited to the overlay only: #4209 (diff)
But the final version of the PR mistakenly merged them together. This patch rectifies that mistake.