Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop redundant styles from .grab-to-pan-grab:active #16896

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Drop redundant styles from .grab-to-pan-grab:active #16896

merged 1 commit into from
Sep 4, 2023

Commits on Sep 3, 2023

  1. Drop redundant styles from .grab-to-pan-grab:active 

    `.grab-to-pan-grab:active` is `#viewerContainer` when the mouse is
pressed down.  It is supposed to have a `cursor: grabbing` appearance
immediately on mousedown,

`.grab-to-pan-grabbing` is the overlay that is supposed to cover
everything, and also has the `cursor: grabbing` appearance. The "cover
everything" result is achieved through `position:fixed`, `inset:0`, etc.

The block with these CSS properties for "cover everything" is currently
shared by `.grab-to-pan-grab:active` and `.grab-to-pan-grabbing`, but
only "cursor" need to be shared. The original JS and CSS code at
https://github.com/Rob--W/grab-to-pan.js shows that these were supposed
to be associated with the overlay only.

The PR that added this to PDF.js also shows that the "cover everything"
CSS properties were supposed to be limited to the overlay only:
mozilla#4209 (diff)

But the final version of the PR mistakenly merged them together.
This patch rectifies that mistake.
    @Rob--W
    Rob--W committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    28bda9f View commit details
    Browse the repository at this point in the history