Upgrade to Gulp 4 #10266

timvandermeij · 2018-11-18T18:31:54Z

This required the following changes in the Gulpfile:

Defining a series of tasks is no longer done with arrays, but with the gulp.series function. The web target is refactored to use a smaller number of tasks to prevent tasks from running multiple times.
Getting all tasks must now be done through the task registry.
Tasks that don't return anything must call done upon completion.

Moreover, this upgrade allows us to use the latest Node.js on Travis CI again.

Fixes most parts of #10177.

timvandermeij · 2018-11-18T18:44:15Z

/botio-linux preview

timvandermeij · 2018-11-18T19:02:50Z

It looks like the global gulp-cli on the bots needs to be updated; refer to gulpjs/gulp-cli#84 (comment). We should already have installed it globally on both bots; refer to https://github.com/mozilla/pdf.js/search?q=%22npm+install+-g%22&unscoped_q=%22npm+install+-g%22.

@brendandahl Could you perhaps update gulp-cli to the latest version on both bots? The CLI is compatible with both Gulp 3 and Gulp 4, so this should be safe to do.

brendandahl · 2018-11-26T18:58:52Z

What version of gulp-cli do we need on the bots?
On linux it looks like we have the latest version:
CLI version 2.0.1
Local version 3.9.1

timvandermeij · 2018-11-26T23:03:22Z

Hm, it looks like gulp-cliis correct then, but it somehow still uses Gulp 3.9.1 instead of Gulp 4. Looking at https://github.com/pattern-lab/edition-node-gulp/wiki/Updating-to-Gulp-4, perhaps it's a difference between the globally installed Gulp and a locally installed Gulp (CLI)?

timvandermeij · 2018-12-11T22:50:25Z

It looks like Gulp 4 got the latest tag just now, so until this is rebased the master builds will fail unfortunately. I'll try to do this soon.

timvandermeij · 2018-12-13T22:17:46Z

/botio-linux preview

pdfjsbot · 2018-12-13T22:17:47Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/bd8161ddbad6eaf/output.txt

pdfjsbot · 2018-12-13T22:22:40Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/bd8161ddbad6eaf/output.txt

Total script time: 4.87 mins

Published

Viewer: http://54.67.70.0:8877/bd8161ddbad6eaf/web/viewer.html

timvandermeij · 2018-12-13T22:23:53Z

/botio lint

pdfjsbot · 2018-12-13T22:23:54Z

From: Bot.io (Linux m4)

Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f2bf6e0cd97ea82/output.txt

pdfjsbot · 2018-12-13T22:23:54Z

From: Bot.io (Windows)

Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/a845b3e3ac01316/output.txt

pdfjsbot · 2018-12-13T22:24:40Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/f2bf6e0cd97ea82/output.txt

Total script time: 0.76 mins

Lint: Passed

pdfjsbot · 2018-12-13T22:26:11Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/a845b3e3ac01316/output.txt

Total script time: 2.28 mins

Lint: Passed

timvandermeij · 2018-12-13T22:27:56Z

/botio unittest

pdfjsbot · 2018-12-13T22:27:57Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a8203b5f0d8a8d3/output.txt

pdfjsbot · 2018-12-13T22:27:57Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/30e2d4e4534fa1c/output.txt

pdfjsbot · 2018-12-13T22:30:21Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/a8203b5f0d8a8d3/output.txt

Total script time: 2.38 mins

Unit Tests: FAILED

pdfjsbot · 2018-12-13T22:32:34Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/30e2d4e4534fa1c/output.txt

Total script time: 4.60 mins

Unit Tests: Passed

timvandermeij · 2018-12-13T22:32:55Z

/botio-linux unittest

pdfjsbot · 2018-12-13T22:32:56Z

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1b45bb6179e5dab/output.txt

pdfjsbot · 2018-12-13T22:35:18Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/1b45bb6179e5dab/output.txt

Total script time: 2.37 mins

Unit Tests: Passed

timvandermeij · 2018-12-13T22:35:38Z

@Snuffleupagus Could you perhaps review this so we can resolve the build failures?

Snuffleupagus · 2018-12-13T22:43:41Z

Looks generally OK, based on a quick look :-)

However, there's two things which seem odd/wrong, but in the interest of un-breaking the builds I suppose that you could fix them in a follow-up PR (assuming it happens relatively soon) rather than here:

Looking at the botio output, e.g. in http://54.67.70.0:8877/bd8161ddbad6eaf/output.txt (from Upgrade to Gulp 4 #10266 (comment) and also on Travis, there's now a bunch of Starting '<anonymous>'... respectively Finished '<anonymous>' lines in the logs.
More problematic, looking again at http://54.67.70.0:8877/bd8161ddbad6eaf/output.txt, it seems that the various gulp tasks are run over-and-over (four times in total) which isn't great.

wojtekmaj · 2018-12-14T10:47:38Z

FYI: This should fix tests on master

timvandermeij · 2018-12-14T21:37:52Z

I'm not entirely sure what happened for the web target that it repeats the tasks. I'll have to look into that; most likely the targets just have superfluous dependencies or there are too many tasks for one purpose. The <anonymous> lines should be fixable by using named functions instead.

wojtekmaj · 2018-12-14T23:30:16Z

Well, that's because you Gulp 4 don't have dependencies!

Here's more info and how to fix:

https://fettblog.eu/gulp-4-parallel-and-series/ CtrlF Gulp 4 does not have any dependency check

TL;DR

gulp.task("after-this", afterThis));
gulp.task("do-this-1", ["after-this"], doThis1));
gulp.task("do-this-2", ["after-this"], doThis2));

-->

gulp.task("after-this", afterThis));
gulp.task("do-this-1", doThis1));
gulp.task("do-this-2", doThis2));
gulp.series("after-this", gulp.parallel("do-this-1", "do-this-2");

This required the following changes in the Gulpfile: - Defining a series of tasks is no longer done with arrays, but with the `gulp.series` function. The `web` target is refactored to use a smaller number of tasks to prevent tasks from running multiple times. - Getting all tasks must now be done through the task registry. - Tasks that don't return anything must call `done` upon completion. Moreover, this upgrade allows us to use the latest Node.js on Travis CI again.

timvandermeij · 2018-12-17T15:25:20Z

/botio-linux preview

pdfjsbot · 2018-12-17T15:25:22Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1ec3a87e513f2b5/output.txt

pdfjsbot · 2018-12-17T15:27:03Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/1ec3a87e513f2b5/output.txt

Total script time: 1.67 mins

Published

Viewer: http://54.67.70.0:8877/1ec3a87e513f2b5/web/viewer.html

timvandermeij · 2018-12-17T15:30:18Z

/botio test

pdfjsbot · 2018-12-17T15:30:19Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/d7c45c1c832a660/output.txt

pdfjsbot · 2018-12-17T15:30:21Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/d4e7ff4823b07db/output.txt

pdfjsbot · 2018-12-17T15:48:09Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/d7c45c1c832a660/output.txt

Total script time: 17.80 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2018-12-17T15:53:32Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/d4e7ff4823b07db/output.txt

Total script time: 23.16 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

timvandermeij · 2018-12-17T15:53:41Z

/botio lint

pdfjsbot · 2018-12-17T15:53:42Z

From: Bot.io (Linux m4)

Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/dcff95b202cdfec/output.txt

pdfjsbot · 2018-12-17T15:53:42Z

From: Bot.io (Windows)

Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/4ef198432368768/output.txt

pdfjsbot · 2018-12-17T15:54:30Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/dcff95b202cdfec/output.txt

Total script time: 0.77 mins

Lint: Passed

pdfjsbot · 2018-12-17T15:56:05Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/4ef198432368768/output.txt

Total script time: 2.36 mins

Lint: Passed

timvandermeij · 2018-12-17T16:02:15Z

Thank you for the feedback, @Snuffleupagus and @wojtekmaj! The builds should succeed again now, we got rid of quite a few old dependencies and Node.js doesn't report vulnerabilities anymore. I'll create a follow-up issue for the remaining improvements.

timvandermeij added the other label Nov 18, 2018

timvandermeij mentioned this pull request Nov 23, 2018

Update natives secondary dependency for Node.js 11.0+ compatibility #10291

Closed

timvandermeij mentioned this pull request Dec 13, 2018

ReferenceError: internalBinding is not defined #10355

Closed

timvandermeij force-pushed the gulp-4 branch from 35e66cf to 1cf959c Compare December 13, 2018 22:13

mozilla deleted a comment from pdfjsbot Dec 13, 2018

timvandermeij force-pushed the gulp-4 branch from 1cf959c to fa85f86 Compare December 17, 2018 15:23

timvandermeij merged commit 417c234 into mozilla:master Dec 17, 2018

timvandermeij deleted the gulp-4 branch December 17, 2018 16:00

alex-gon mentioned this pull request Jun 3, 2019

upgrade gulp to 4.0.0 MasterControlIncPublic/pdf.js#2

Closed

Snuffleupagus mentioned this pull request Jun 4, 2021

Miscellaneous improvements for gulpfile.js (issue 10362) #13490

Merged

Upgrade to Gulp 4 #10266

Upgrade to Gulp 4 #10266

Conversation

timvandermeij commented Nov 18, 2018 • edited Loading

timvandermeij commented Nov 18, 2018

timvandermeij commented Nov 18, 2018 • edited Loading

brendandahl commented Nov 26, 2018

timvandermeij commented Nov 26, 2018

timvandermeij commented Dec 11, 2018 • edited Loading

timvandermeij commented Dec 13, 2018

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Success

Published

timvandermeij commented Dec 13, 2018

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Dec 13, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Success

pdfjsbot commented Dec 13, 2018

From: Bot.io (Windows)

Success

timvandermeij commented Dec 13, 2018

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Dec 13, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Dec 13, 2018

From: Bot.io (Windows)

Success

timvandermeij commented Dec 13, 2018

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Dec 13, 2018

From: Bot.io (Linux m4)

Success

timvandermeij commented Dec 13, 2018

Snuffleupagus commented Dec 13, 2018

wojtekmaj commented Dec 14, 2018

timvandermeij commented Dec 14, 2018

wojtekmaj commented Dec 14, 2018

timvandermeij commented Dec 17, 2018

pdfjsbot commented Dec 17, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Dec 17, 2018

From: Bot.io (Linux m4)

Success

Published

timvandermeij commented Dec 17, 2018

pdfjsbot commented Dec 17, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Dec 17, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Dec 17, 2018

From: Bot.io (Linux m4)

Success

pdfjsbot commented Dec 17, 2018

From: Bot.io (Windows)

Success

timvandermeij commented Dec 17, 2018

pdfjsbot commented Dec 17, 2018

From: Bot.io (Linux m4)

Received

timvandermeij commented Nov 18, 2018 •

edited

Loading

timvandermeij commented Nov 18, 2018 •

edited

Loading

timvandermeij commented Dec 11, 2018 •

edited

Loading