Miscellaneous improvements for gulpfile.js (issue 10362)
#13490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue 10362) This replaces all of the `Starting '<anonymous>'...` lines in the output, when running various `gulp` tasks, with more meaningful function names.
Most of the `gulp` tasks with a "-pre" suffix, especially those related to the main build-targets, are no longer needed and can simply be inlined in their corresponding tasks. This is likely a left-over from older Gulp-versions, but currently it only adds unnecessary indirection. Furthermore, a number of the `gulp` tasks which are only used *internally* are converted to standard functions instead. This prevents them from being exposed "globally" and e.g. listed by `gulp default`.
Snuffleupagus
force-pushed
the
issue-10362
branch
from
63ec4b9
to
bdf29ec
Compare
|
With this PR, |
Looking at the history of the code, this `gulp` task was *accidentally* broken in the Gulp 4 upgrade in PR 10266 (all the way back in 2018). Given that no one has either noticed and/or complained about this since, it's safe to assume that it's completely unused, hence why I suggest that we just remove this `gulp` task (rather than fixing it).
Snuffleupagus
force-pushed
the
issue-10362
branch
from
bdf29ec
to
66a5671
Compare
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5c43b6a2cffcb80/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/0acd2b1520e2086/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5c43b6a2cffcb80/output.txt Total script time: 2.48 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/0acd2b1520e2086/output.txt Total script time: 5.19 mins
|
timvandermeij
approved these changes
Jun 4, 2021
|
Looks much better; thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace anonymous functions in
gulpfile.jswith named functions (issue 10362)This replaces all of the
Starting '<anonymous>'...lines in the output, when running variousgulptasks, with more meaningful function names.Clean-up
gulpfile.jsby removing most "-pre" tasks (issue 10362)Most of the
gulptasks with a "-pre" suffix, especially those related to the main build-targets, are no longer needed and can simply be inlined in their corresponding tasks. This is likely a left-over from older Gulp-versions, but currently it only adds unnecessary indirection.Furthermore, a number of the
gulptasks which are only used internally are converted to standard functions instead. This prevents them from being exposed "globally" and e.g. listed bygulp default.Remove
gulp makefile, since it's broken and unusedLooking at the history of the code, this
gulptask was accidentally broken in the Gulp 4 upgrade in PR Upgrade to Gulp 4 #10266 (all the way back in 2018).Given that no one has either noticed and/or complained about this since, it's safe to assume that it's completely unused, hence why I suggest that we just remove this
gulptask (rather than fixing it).Fixes #10362