Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous improvements for gulpfile.js (issue 10362) #13490

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Miscellaneous improvements for gulpfile.js (issue 10362) #13490

merged 3 commits into from
Jun 4, 2021

Commits on Jun 4, 2021

  1. Replace anonymous functions in gulpfile.js with named functions (is… 

    …sue 10362)

This replaces all of the `Starting '<anonymous>'...` lines in the output, when running various `gulp` tasks, with more meaningful function names.
    @Snuffleupagus
    Snuffleupagus committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    92434b1 View commit details
    Browse the repository at this point in the history

  2. Clean-up gulpfile.js by removing most "-pre" tasks (issue 10362) 

    Most of the `gulp` tasks with a "-pre" suffix, especially those related to the main build-targets, are no longer needed and can simply be inlined in their corresponding tasks. This is likely a left-over from older Gulp-versions, but currently it only adds unnecessary indirection.

Furthermore, a number of the `gulp` tasks which are only used *internally* are converted to standard functions instead. This prevents them from being exposed "globally" and e.g. listed by `gulp default`.
    @Snuffleupagus
    Snuffleupagus committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    6c249f8 View commit details
    Browse the repository at this point in the history

  3. Remove gulp makefile, since it's broken and unused 

    Looking at the history of the code, this `gulp` task was *accidentally* broken in the Gulp 4 upgrade in PR 10266 (all the way back in 2018).
Given that no one has either noticed and/or complained about this since, it's safe to assume that it's completely unused, hence why I suggest that we just remove this `gulp` task (rather than fixing it).
    @Snuffleupagus
    Snuffleupagus committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    66a5671 View commit details
    Browse the repository at this point in the history