#10344 fix #10345
Closed
#10344 fix #10345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linter complains line length >80 (83)
| @@ -545,16 +545,15 @@ var PDFDocument = (function PDFDocumentClosure() { | |||
| } | |||
| if (isDict(infoDict)) { | |||
| // Only fill the document info with valid entries from the spec. | |||
There was a problem hiding this comment.
This patch is very clearly breaking the assumption listed above, which exists to prevent errors since not all data structures (one example is Dict) can be sent from the worker to the main thread.
Assuming first of all that this is even desired functionality, the patch unfortunately cannot be accepted in its current form (furthermore there's also the issue of no tests being include here).
There was a problem hiding this comment.
Okay, then what is the intended functionality? Info dict is clearly in the specs since every PDF accepts custom info dict entries. I do not see any discussions among the issues about this matter.
|
Closing in favor of the more complete solution in #10346. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #10344
Iterate all keys in
infoDictinstead of all keys inDocumentInfoValidatorswhichinfoDicthas the same key of, so as to not ignore the custom info dict entries.