[api-minor] Add support, in getMetadata, for custom information dictionary entries (issue 5970, issue 10344)
#10346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio unittest |
Snuffleupagus
force-pushed
the
infoDict-custom
branch
from
9306ef3
to
2b438e9
Compare
…tionary entries (issue 5970, issue 10344) The custom entries, provided that they exist *and* that their types are safe to include, are exposed through a new `Custom` infoDict entry to clearly separate them from the standard ones. Fixes 5970. Fixes 10344.
Snuffleupagus
force-pushed
the
infoDict-custom
branch
from
2b438e9
to
ef7e671
Compare
Closed
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f35f626c3acb425/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/d4811f7596d046a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f35f626c3acb425/output.txt Total script time: 17.92 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/d4811f7596d046a/output.txt Total script time: 23.43 mins
|
timvandermeij
approved these changes
Dec 18, 2018
|
Nice extension; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom entries, provided that they exist and that their types are safe to include, are exposed through a new
CustominfoDict entry to clearly separate them from the standard ones.Fixes #5970.
Fixes #10344.