support urlencode contentDispositionFilename #10381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
requested changes
Dec 26, 2018
| @@ -1074,6 +1074,9 @@ let PDFViewerApplication = { | |||
| ({ info, metadata, contentDispositionFilename, }) => { | |||
| this.documentInfo = info; | |||
| this.metadata = metadata; | |||
| if(contentDispositionFilename && contentDispositionFilename.includes('%')){ | |||
There was a problem hiding this comment.
This does not look like the correct place to fix it. Instead, it should be fixed in the function where the content disposition filename is fetched, most likely extractFilenameFromHeader. Moreover, a unit test needs to be added to
pdf.js/test/unit/network_utils_spec.js
Line 161 in f45e46d
|
Closing since this cannot be merged in the current state and no response was given. If you do believe something is wrong in PDF.js, please open an issue so we can discuss it and find out what the best fix would be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.