Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support urlencode contentDispositionFilename #10381

Closed
wants to merge 2 commits into from
Closed

support urlencode contentDispositionFilename #10381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999f01d
support urlencode filename
wangsongyan Dec 26, 2018
e48a81e
support urlencode contentDispositionFilename
wangsongyan Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions web/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,9 @@ let PDFViewerApplication = {
({ info, metadata, contentDispositionFilename, }) => {
this.documentInfo = info;
this.metadata = metadata;
if(contentDispositionFilename && contentDispositionFilename.includes('%')){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like the correct place to fix it. Instead, it should be fixed in the function where the content disposition filename is fetched, most likely extractFilenameFromHeader. Moreover, a unit test needs to be added to

pdf.js/test/unit/network_utils_spec.js

Line 161 in f45e46d

describe('extractFilenameFromHeader', function() {
to make sure it works. Finally, please elaborate a bit about what the exact problem is in the pull request description.

contentDispositionFilename = decodeURIComponent(contentDispositionFilename);
}
this.contentDispositionFilename = contentDispositionFilename;

// Provides some basic debug information
Expand Down