Actually transfer eligible ImageMask data, rather than always copying it #10647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By transfering
ArrayBuffer
s you can avoid having two copies of the same data, i.e. one copy on each of the worker/main-thread, for data that's used only once on the worker-thread.Note how the code in
PDFImage.createMask
goes to great lengths to actually enable tranfering of the image data. However inPartialEvaluator.buildPaintImageXObject
thecached
property is always set totrue
, which disqualifies the image data from being transfered; seegetTransfers
.For most ImageMask data this patch won't matter, since images found in the
/Resources -> /XObject
dictionary will always be indexed by name. However for inline images which contains ImageMask data, where only "small" images are cached (in bothparser.js
andevaluator.js
), the current code will result in some unnecessary memory usage.