Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually transfer eligible ImageMask data, rather than always copying it #10647

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Actually transfer eligible ImageMask data, rather than always copying it #10647

merged 2 commits into from
Mar 16, 2019

Commits on Mar 16, 2019

  1. Actually transfer eligible ImageMask data, rather than always copying it 

    By transfering `ArrayBuffer`s you can avoid having two copies of the same data, i.e. one copy on each of the worker/main-thread, for data that's used only *once* on the worker-thread.

Note how the code in [`PDFImage.createMask`](https://github.com/mozilla/pdf.js/blob/80135378cadd98b55a835446f0857e4bc30524e0/src/core/image.js#L284-L285) goes to great lengths to actually enable tranfering of the image data. However in [`PartialEvaluator.buildPaintImageXObject`](https://github.com/mozilla/pdf.js/blob/80135378cadd98b55a835446f0857e4bc30524e0/src/core/evaluator.js#L336) the `cached` property is always set to `true`, which disqualifies the image data from being transfered; see [`getTransfers`](https://github.com/mozilla/pdf.js/blob/80135378cadd98b55a835446f0857e4bc30524e0/src/core/operator_list.js#L552-L554).

For most ImageMask data this patch won't matter, since images found in the `/Resources -> /XObject` dictionary will always be indexed by name. However for *inline* images which contains ImageMask data, where only "small" images are cached (in both `parser.js` and `evaluator.js`), the current code will result in some unnecessary memory usage.
    @Snuffleupagus
    Snuffleupagus committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    7273795 View commit details
    Browse the repository at this point in the history

  2. Re-factor the getTransfers helper function into a "private" getter … 

    …method on the `OperatorList`

This function is currently called with the `OperatorList` instance as its argument, hence I cannot think of any good reason for not just moving it into the `OperatorList` properly. (This will also help with other planned changes regarding the `ImageCache` functionality.)
    @Snuffleupagus
    Snuffleupagus committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    56eeeea View commit details
    Browse the repository at this point in the history