Remove the supportsDocumentColors warning in MOZCENTRAL builds (bug 844349 follow-up)
#11521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to classes with static methods This seems nicer overall, since it's now a bit clearer that the various build targets *extend* the default implementation.
… 844349 follow-up) With https://bugzilla.mozilla.org/show_bug.cgi?id=844349 now being fixed in Firefox, the textLayer will now actually stay hidden as intended regardless of the browser settings. Hence it should no longer be necessary to display the fallback bar, nor print a warning in the console, for documents which contains a textLayer. Besides removing the `supportsDocumentColors` methods in the default viewer, we can also remove a now unused l10n string.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6d12d1c5a7ff4ca/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6d12d1c5a7ff4ca/output.txt Total script time: 9.40 mins Published |
timvandermeij
approved these changes
Jan 19, 2020
|
Nice clean-up! |
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Mar 27, 2020
…Viewer. r=bdahl As part of the work to clean-up the event dispatching in the PDF Viewer, particularily re-dispatching of internal `EventBus` events to the DOM, this patch is necessary to unblock the upstream work that's currently pending in [PR 11655](mozilla/pdf.js#11655). Finally, the patch also removes the `ChromeActions.supportsDocumentColors` method given that it's been unused since [bug 1611175](https://bugzilla.mozilla.org/show_bug.cgi?id=1611175) and [PR 11521](mozilla/pdf.js#11521). Differential Revision: https://phabricator.services.mozilla.com/D68533
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 28, 2020
…Viewer. r=bdahl As part of the work to clean-up the event dispatching in the PDF Viewer, particularily re-dispatching of internal `EventBus` events to the DOM, this patch is necessary to unblock the upstream work that's currently pending in [PR 11655](mozilla/pdf.js#11655). Finally, the patch also removes the `ChromeActions.supportsDocumentColors` method given that it's been unused since [bug 1611175](https://bugzilla.mozilla.org/show_bug.cgi?id=1611175) and [PR 11521](mozilla/pdf.js#11521). Differential Revision: https://phabricator.services.mozilla.com/D68533 --HG-- extra : moz-landing-system : lando
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 31, 2020
…Viewer. r=bdahl As part of the work to clean-up the event dispatching in the PDF Viewer, particularily re-dispatching of internal `EventBus` events to the DOM, this patch is necessary to unblock the upstream work that's currently pending in [PR 11655](mozilla/pdf.js#11655). Finally, the patch also removes the `ChromeActions.supportsDocumentColors` method given that it's been unused since [bug 1611175](https://bugzilla.mozilla.org/show_bug.cgi?id=1611175) and [PR 11521](mozilla/pdf.js#11521). Differential Revision: https://phabricator.services.mozilla.com/D68533 UltraBlame original commit: 535dc6cf908145933612e554ca3680013a154757
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 31, 2020
…Viewer. r=bdahl As part of the work to clean-up the event dispatching in the PDF Viewer, particularily re-dispatching of internal `EventBus` events to the DOM, this patch is necessary to unblock the upstream work that's currently pending in [PR 11655](mozilla/pdf.js#11655). Finally, the patch also removes the `ChromeActions.supportsDocumentColors` method given that it's been unused since [bug 1611175](https://bugzilla.mozilla.org/show_bug.cgi?id=1611175) and [PR 11521](mozilla/pdf.js#11521). Differential Revision: https://phabricator.services.mozilla.com/D68533 UltraBlame original commit: 535dc6cf908145933612e554ca3680013a154757
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 31, 2020
…Viewer. r=bdahl As part of the work to clean-up the event dispatching in the PDF Viewer, particularily re-dispatching of internal `EventBus` events to the DOM, this patch is necessary to unblock the upstream work that's currently pending in [PR 11655](mozilla/pdf.js#11655). Finally, the patch also removes the `ChromeActions.supportsDocumentColors` method given that it's been unused since [bug 1611175](https://bugzilla.mozilla.org/show_bug.cgi?id=1611175) and [PR 11521](mozilla/pdf.js#11521). Differential Revision: https://phabricator.services.mozilla.com/D68533 UltraBlame original commit: 535dc6cf908145933612e554ca3680013a154757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://bugzilla.mozilla.org/show_bug.cgi?id=844349 now being fixed in Firefox, the textLayer will now actually stay hidden as intended regardless of the browser settings.
Hence it should no longer be necessary to display the fallback bar, nor print a warning in the console, for documents which contains a textLayer.
Besides removing the
supportsDocumentColorsmethods in the default viewer, we can also remove a now unused l10n string.