Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the supportsDocumentColors warning in MOZCENTRAL builds (bug 844349 follow-up) #11521

Merged
merged 2 commits into from
Jan 19, 2020

Commits on Jan 15, 2020

  1. Re-factor the various ExternalServices, used in the default viewer,…

    … to classes with static methods
    
    This seems nicer overall, since it's now a bit clearer that the various build targets *extend* the default implementation.
    Snuffleupagus committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    1b87b1c View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2020

  1. Remove the supportsDocumentColors warning in MOZCENTRAL builds (bug…

    … 844349 follow-up)
    
    With https://bugzilla.mozilla.org/show_bug.cgi?id=844349 now being fixed in Firefox, the textLayer will now actually stay hidden as intended regardless of the browser settings.
    Hence it should no longer be necessary to display the fallback bar, nor print a warning in the console, for documents which contains a textLayer.
    
    Besides removing the `supportsDocumentColors` methods in the default viewer, we can also remove a now unused l10n string.
    Snuffleupagus committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    a977882 View commit details
    Browse the repository at this point in the history