print: Make the firefox printing code able to fail and be re-invoked. #12315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
force-pushed
the
more-resilient-print-callback
branch
from
13cd49d
to
b92fad4
Compare
This fixes a set of issues described in Mozilla bug 1662426[1]. In particular, once the print callback fails once (because the printing operation has been canceled in Gecko / replaced by a newer one, for example) it can't be re-invoked. This patch fixes it by properly cancelling the render task if it throws, or if the print callback is called again while ongoing. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1662426
|
I added a comment, let me know if you want me to tweak it :) |
emilio
force-pushed
the
more-resilient-print-callback
branch
from
b92fad4
to
f4f4ec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a set of issues described in Mozilla bug 16624261.
In particular, once the print callback fails once (because the printing
operation has been canceled in Gecko / replaced by a newer one, for example) it
can't be re-invoked.
This patch fixes it by properly cancelling the render task if it throws, or if
the print callback is called again while ongoing.