Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print: Make the firefox printing code able to fail and be re-invoked. #12315

Merged
merged 1 commit into from
Sep 2, 2020
Merged

print: Make the firefox printing code able to fail and be re-invoked. #12315

merged 1 commit into from
Sep 2, 2020

Commits on Sep 2, 2020

  1. print: Make the firefox printing code able to fail and be re-invoked. 

    This fixes a set of issues described in Mozilla bug 1662426[1].

In particular, once the print callback fails once (because the printing
operation has been canceled in Gecko / replaced by a newer one, for example) it
can't be re-invoked.

This patch fixes it by properly cancelling the render task if it throws, or if
the print callback is called again while ongoing.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1662426
    @emilio
    emilio committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    f4f4ec3 View commit details
    Browse the repository at this point in the history