Attempt to handle collapsed outline items, in the default viewer, according to the specification (issue 12704, PR 10890 follow-up) #12712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ording to the specification (issue 12704, PR 10890 follow-up) This patch *attempts* to actually implement what's described for the `Count`-entry in the PDF specification, see https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G11.2095911, which I mostly ignored back in PR 10890 since it seemed unnecessarily complicated[1]. Besides issue 12704, I've also tested a couple of other documents (e.g. the PDF specification) and these changes don't *seem* to break anything else; additional testing would be helpful though! --- [1] At the time, all PDF documents that I tested worked even with a very simple approach and I thus hoped that it'd would suffice.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/838b9133c52dacf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/838b9133c52dacf/output.txt Total script time: 4.22 mins Published |
timvandermeij
approved these changes
Dec 9, 2020
|
Looks good to me, also in my testing with some other PDF files. I did have to re-read the specification a couple of times to actually understand what they mean, so I share the feeling that the idea of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to actually implement what's described for the
Count-entry in the PDF specification, see https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G11.2095911, which I mostly ignored back in PR #10890 since it seemed unnecessarily complicated[1].Besides issue #12704, I've also tested a couple of other documents (e.g. the PDF specification) and these changes don't seem to break anything else; additional testing would be helpful though!
Fixes #12704
[1] At the time, all PDF documents that I tested worked even with a very simple approach and I thus hoped that it'd would suffice.