Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to handle collapsed outline items, in the default viewer, according to the specification (issue 12704, PR 10890 follow-up) #12712

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Attempt to handle collapsed outline items, in the default viewer, according to the specification (issue 12704, PR 10890 follow-up) #12712

merged 1 commit into from
Dec 9, 2020

Commits on Dec 9, 2020

  1. Attempt to handle collapsed outline items, in the default viewer, acc… 

    …ording to the specification (issue 12704, PR 10890 follow-up)

This patch *attempts* to actually implement what's described for the `Count`-entry in the PDF specification, see https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G11.2095911, which I mostly ignored back in PR 10890 since it seemed unnecessarily complicated[1].

Besides issue 12704, I've also tested a couple of other documents (e.g. the PDF specification) and these changes don't *seem* to break anything else; additional testing would be helpful though!

---
[1] At the time, all PDF documents that I tested worked even with a very simple approach and I thus hoped that it'd would suffice.
    @Snuffleupagus
    Snuffleupagus committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    09f79ff View commit details
    Browse the repository at this point in the history